Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(281)

Issue 9570052: Add a boolean histogram "Chrome.CommandLineUseSystemSSL" to keep track of (Closed)

Created:
8 years, 9 months ago by kaiwang
Modified:
8 years, 9 months ago
CC:
jam, chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

Add a boolean histogram "Chrome.CommandLineUseSystemSSL" to keep track of "--use-system-ssl" usage. The flag forces the user to use SSLClientSocket[Mac, Win], instead of the default NSS SSL implementation. I also changed the order of initialize callings in BrowserMainRunnerImpl::Initialize(), because originally the StatisticsRecorder was created after main loop flag parsing so the new histogram can not be recorded. Since StatisticsRecorder has few dependencies, I think this will not have negative effect. BUG=102003 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=124770

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 2

Patch Set 4 : #

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -4 lines) Patch
M content/browser/browser_main_loop.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/browser_main_runner.cc View 1 2 3 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
kaiwang
Hi Marshall, Could you take a look at my change of browser_main_runner.cc? I've changed the ...
8 years, 9 months ago (2012-03-02 00:54:16 UTC) #1
Marshall
http://codereview.chromium.org/9570052/diff/4/content/browser/browser_main_runner.cc File content/browser/browser_main_runner.cc (right): http://codereview.chromium.org/9570052/diff/4/content/browser/browser_main_runner.cc#newcode44 content/browser/browser_main_runner.cc:44: statistics_.reset(new base::StatisticsRecorder); This should probably come after the WaitForDebugger ...
8 years, 9 months ago (2012-03-02 02:14:06 UTC) #2
kaiwang
http://codereview.chromium.org/9570052/diff/4/content/browser/browser_main_runner.cc File content/browser/browser_main_runner.cc (right): http://codereview.chromium.org/9570052/diff/4/content/browser/browser_main_runner.cc#newcode44 content/browser/browser_main_runner.cc:44: statistics_.reset(new base::StatisticsRecorder); On 2012/03/02 02:14:06, Marshall wrote: > This ...
8 years, 9 months ago (2012-03-02 04:26:56 UTC) #3
Marshall
lgtm but an owner will need to approve.
8 years, 9 months ago (2012-03-02 17:00:45 UTC) #4
jar (doing other things)
LGTM You'll probably need a OWNERS review from content... so I'm adding Jam (to get ...
8 years, 9 months ago (2012-03-02 18:34:51 UTC) #5
jam
lgtm
8 years, 9 months ago (2012-03-02 19:13:10 UTC) #6
kaiwang
Trybot now passed my change (seems last error was a flacky error). I'm going to ...
8 years, 9 months ago (2012-03-02 21:25:21 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kaiwang@chromium.org/9570052/11001
8 years, 9 months ago (2012-03-02 21:25:31 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kaiwang@chromium.org/9570052/11001
8 years, 9 months ago (2012-03-02 21:27:37 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kaiwang@chromium.org/9570052/11001
8 years, 9 months ago (2012-03-02 21:29:09 UTC) #10
commit-bot: I haz the power
8 years, 9 months ago (2012-03-02 23:34:35 UTC) #11
Change committed as 124770

Powered by Google App Engine
This is Rietveld 408576698