Defer shutting down Chrome after the CF automation connection goes away.

chrome/browser/automation/chrome_frame_automation_provider.cc

-// Copyright (c) 2011 The Chromium Authors. All rights reserved.
+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/automation/chrome_frame_automation_provider.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/profiles/profile_manager.h"
 #include "chrome/common/automation_messages.h"
 #include "ipc/ipc_message.h"
 #include "ipc/ipc_channel.h"
 
+
+const int kShutdownDelaySeconds = 30;

[slightlyoff, 2012/03/01 16:57:12]

Would be great to make this controllable from the registry so that we can
experiment with values easily.

[robertshield, 2012/03/02 15:17:17]

True, but this runs on the UI thread which (I think) needs to defer off to
another thread for registry access. Also, a registry value won't do for
in-the-field experiments without a lot of extra plumbing through the installer.
Mind if I mark this as a TODO() for now?

+
 ChromeFrameAutomationProvider::ChromeFrameAutomationProvider(Profile* profile)
     : AutomationProvider(profile) {
   DCHECK(g_browser_process);
   if (g_browser_process)
     g_browser_process->AddRefModule();
 }
 
 ChromeFrameAutomationProvider::~ChromeFrameAutomationProvider() {
   DCHECK(g_browser_process);
-  if (g_browser_process)
-    g_browser_process->ReleaseModule();
+  if (g_browser_process) {
+    // We have Chrome Frame defer Chrome shutdown for a time to improve
+    // intra-page load times.
+    MessageLoop::current()->PostDelayedTask(
+        FROM_HERE,
+        base::Bind(&ChromeFrameAutomationProvider::ReleaseBrowserProcess),
+        base::TimeDelta::FromSeconds(kShutdownDelaySeconds));
+  }
 }
 

[slightlyoff, 2012/03/01 16:57:12]

extra newline?

[grt (UTC plus 2), 2012/03/01 16:59:31]

remove extra newline

[robertshield, 2012/03/02 15:17:17]

Done.

[robertshield, 2012/03/02 15:17:17]

Done.

+
 bool ChromeFrameAutomationProvider::OnMessageReceived(
     const IPC::Message& message) {
   if (IsValidMessage(message.type()))
     return AutomationProvider::OnMessageReceived(message);
 
   OnUnhandledMessage(message);
   return false;
 }
 
 void ChromeFrameAutomationProvider::OnUnhandledMessage(
@@ skipping 43 matching lines @@
       is_valid_message = true;
       break;
     }
 
     default:
       break;
   }
 
   return is_valid_message;
 }
+
+// static
+void ChromeFrameAutomationProvider::ReleaseBrowserProcess() {
+  if (g_browser_process) {

[grt (UTC plus 2), 2012/03/01 16:59:31]

remove extra braces

[robertshield, 2012/03/02 15:17:17]

Done.

+    g_browser_process->ReleaseModule();
+  }
+}