Activate the status area only when it's focused using the keyboard

ash/system/tray/system_tray.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/system/tray/system_tray.h"
 
+#include "ash/shell.h"
 #include "ash/shell/panel_window.h"
+#include "ash/shell_delegate.h"
 #include "ash/system/tray/system_tray_item.h"
 #include "ash/wm/shadow_types.h"
 #include "base/logging.h"
 #include "base/utf_string_conversions.h"
 #include "third_party/skia/include/core/SkColor.h"
+#include "ui/aura/client/activation_client.h"
 #include "ui/views/border.h"
 #include "ui/views/bubble/bubble_delegate.h"
 #include "ui/views/controls/label.h"
 #include "ui/views/layout/box_layout.h"
 #include "ui/views/view.h"
 
 namespace {
 
 const int kTrayIconHeight = 50;
 const int kPadding = 5;
@@ skipping 12 matching lines @@
 
   virtual ~SystemTrayBubble() {
     for (std::vector<ash::SystemTrayItem*>::iterator it = items_.begin();
         it != items_.end();
         ++it) {
       if (detailed_)
         (*it)->DestroyDetailedView();
       else
         (*it)->DestroyDefaultView();
     }
+    ActivateBrowserWindow();
   }
 
  private:
   // Overridden from views::BubbleDelegateView.
   virtual void Init() OVERRIDE {
     SetLayoutManager(new views::BoxLayout(views::BoxLayout::kVertical,
           0, 0, 1));
 
     for (std::vector<ash::SystemTrayItem*>::iterator it = items_.begin();
         it != items_.end();
         ++it) {
       views::View* view = detailed_ ? (*it)->CreateDetailedView() :
                                       (*it)->CreateDefaultView();
       if (it != items_.begin())
         view->set_border(views::Border::CreateSolidSidedBorder(
               1, 0, 0, 0, SkColorSetARGB(25, 0, 0, 0)));
       AddChildView(view);
     }
   }
 
+  void ActivateBrowserWindow() {
+    const std::vector<aura::Window*>& windows =
+        ash::Shell::GetInstance()->delegate()->GetCycleWindowList(

[Daniel Erat, 2012/03/02 16:49:19]

it seems a bit strange to have this class reach in and do this itself instead of
just asking the shell or some other class within the shell to focus a browser.

[Yusuke Sato, 2012/03/05 12:56:24]

Removed the code. Modified kWindowContainerIds[] in activation_controller.cc
instead.

On 2012/03/02 16:49:19, Daniel Erat wrote:

+            ash::ShellDelegate::SOURCE_LAUNCHER, ash::ShellDelegate::ORDER_MRU);
+    if (!windows.empty()) {
+      aura::client::GetActivationClient(ash::Shell::GetRootWindow())->
+          ActivateWindow(windows[0]);
+    }
+  }
+
   ash::SystemTray* tray_;
   std::vector<ash::SystemTrayItem*> items_;
   bool detailed_;
 
   DISALLOW_COPY_AND_ASSIGN(SystemTrayBubble);
 };
 
 }  // namespace
 
 namespace ash {
@@ skipping 52 matching lines @@
     ShowItems(items_, false);
   return true;
 }
 
 void SystemTray::OnWidgetClosing(views::Widget* widget) {
   CHECK_EQ(popup_, widget);
   popup_ = NULL;
 }
 
 }  // namespace ash