content/browser/download/download_file_manager.cc - Issue 9570005: Added callback to DownloadUrl() so we can find download failures.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/download/download_file_manager.cc

Issue 9570005: Added callback to DownloadUrl() so we can find download failures. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Merged with trunk Created 8 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/download/download_file_manager.cc

diff --git a/content/browser/download/download_file_manager.cc b/content/browser/download/download_file_manager.cc

index 3d608a489b76e82eb11b655543de69c9cd5a12fb..82aba337546be3ffeec8f43580afae74031fb011 100644

--- a/content/browser/download/download_file_manager.cc

+++ b/content/browser/download/download_file_manager.cc

@@ -177,11 +177,7 @@ void DownloadFileManager::StartDownload(

DCHECK(info);

DownloadManager* manager = request_handle.GetDownloadManager();

- if (!manager) {

- request_handle.CancelRequest();

- delete info;

- return;

- }

+ DCHECK(manager); // Checked in |DownloadResourceHandler::StartOnUIThread()|.

// |bound_net_log| will be used for logging the both the download item's and

// the download file's events.