Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(512)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: content/browser/download/download_file_manager.cc

Issue 9570005: Added callback to DownloadUrl() so we can find download failures. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Merged with parent. Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/tab_contents/render_view_context_menu.cc ('k') | content/browser/download/download_manager_impl.h » ('j') | content/browser/renderer_host/resource_dispatcher_host.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/download/download_file_manager.cc
diff --git a/content/browser/download/download_file_manager.cc b/content/browser/download/download_file_manager.cc
index 00126d0ef7914d901e71bbae18914ec043485861..277ac5bac4ed39058fb9058b521c5410f07ffe20 100644
--- a/content/browser/download/download_file_manager.cc
+++ b/content/browser/download/download_file_manager.cc
@@ -179,11 +179,7 @@ void DownloadFileManager::StartDownload(
DCHECK(info);
DownloadManager* manager = request_handle.GetDownloadManager();
- if (!manager) {
- request_handle.CancelRequest();
- delete info;
- return;
- }
+ DCHECK(manager); // Checked in |DownloadResourceHandler::StartOnUIThread()|.
// |bound_net_log| will be used for logging the both the download item's and
// the download file's events.
« no previous file with comments | « chrome/browser/tab_contents/render_view_context_menu.cc ('k') | content/browser/download/download_manager_impl.h » ('j') | content/browser/renderer_host/resource_dispatcher_host.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698