content/browser/download/download_resource_handler.h - Issue 9570005: Added callback to DownloadUrl() so we can find download failures.

Unified Diff: content/browser/download/download_resource_handler.h

Issue 9570005: Added callback to DownloadUrl() so we can find download failures. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Merged with trunk Created 8 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/download/download_resource_handler.h

diff --git a/content/browser/download/download_resource_handler.h b/content/browser/download/download_resource_handler.h

index df363686265f2b952da59f5077c71fa97b5bc6c7..ce7b49c4717f9607c59768875c659969232ef0e5 100644

--- a/content/browser/download/download_resource_handler.h

+++ b/content/browser/download/download_resource_handler.h

@@ -13,6 +13,7 @@

#include "base/timer.h"

#include "content/browser/download/download_types.h"

#include "content/browser/renderer_host/resource_handler.h"

+#include "content/public/browser/download_manager.h"

#include "content/public/browser/download_id.h"

#include "content/public/browser/global_request_id.h"

#include "net/base/net_errors.h"

@@ -33,8 +34,7 @@ class URLRequest;

// Forwards data to the download thread.

class DownloadResourceHandler : public ResourceHandler {

public:

- typedef base::Callback<void(content::DownloadId, net::Error)>

- OnStartedCallback;

+ typedef content::DownloadManager::OnStartedCallback OnStartedCallback;

Randy Smith (Not in Mondays) 2012/03/01 21:17:24 I don't think there's any reason for this to be in

ahendrickson 2012/03/02 17:34:39 True, but then I would have to change 5 other file

Randy Smith (Not in Mondays) 2012/03/06 21:29:14 Got it--thanks for the explanation. I'm good with

static const size_t kLoadsToWrite = 100; // number of data buffers queued