chrome/browser/extensions/webstore_installer.cc - Issue 9570005: Added callback to DownloadUrl() so we can find download failures.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/webstore_installer.cc

Issue 9570005: Added callback to DownloadUrl() so we can find download failures. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Added thread checks. Created 8 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/webstore_installer.cc

diff --git a/chrome/browser/extensions/webstore_installer.cc b/chrome/browser/extensions/webstore_installer.cc

index 91aa03d20039fbec822de28aeb25f008fd6571ae..b472634b83f5d722d5d086fce916849264b5e157 100644

--- a/chrome/browser/extensions/webstore_installer.cc

+++ b/chrome/browser/extensions/webstore_installer.cc

@@ -215,7 +215,8 @@ void WebstoreInstaller::StartDownload(FilePath file) {

download_util::INITIATED_BY_WEBSTORE_INSTALLER);

profile_->GetDownloadManager()->DownloadUrl(

download_url_, referrer, "",

- false, -1, save_info, controller_->GetWebContents());

+ false, -1, save_info, controller_->GetWebContents(),

+ content::DownloadManager::OnStartedCallback());

}

void WebstoreInstaller::ReportFailure(const std::string& error) {