Added callback to DownloadUrl() so we can find download failures.

chrome/browser/download/download_test_observer.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <vector>
 
 #include "base/bind.h"
 #include "base/logging.h"
 #include "base/message_loop.h"
 #include "base/stl_util.h"
@@ skipping 328 matching lines @@
 void DownloadTestFlushObserver::PingIOThread(int cycle) {
   if (--cycle) {
     BrowserThread::PostTask(
         BrowserThread::UI, FROM_HERE,
         base::Bind(&DownloadTestFlushObserver::PingFileThread, this, cycle));
   } else {
     BrowserThread::PostTask(
         BrowserThread::UI, FROM_HERE, MessageLoop::QuitClosure());
   }
 }
+
+DownloadTestItemCreationObserver::~DownloadTestItemCreationObserver() {
+}
+
+DownloadTestItemCreationObserver::DownloadTestItemCreationObserver()
+    : called_back_count_(0),
+      waiting_(false),
+      ALLOW_THIS_IN_INITIALIZER_LIST(callback_(base::Bind(
+          &DownloadTestItemCreationObserver::DownloadItemCreationCallback,
+          this))) {
+}
+
+void DownloadTestItemCreationObserver::WaitForDownloadItemCreation() {
+  if (called_back_count_ == 0) {
+    waiting_ = true;
+    ui_test_utils::RunMessageLoop();
+    waiting_ = false;
+  }
+}
+
+void DownloadTestItemCreationObserver::DownloadItemCreationCallback(
+    content::DownloadId download_id, net::Error error) {
+  creation_info_.download_id = download_id;

[cbentzel, 2012/03/02 21:00:18]

Can you add a DCHECK that this is called on the UI thread? 

[ahendrickson, 2012/03/02 21:51:41]

Done.

+  creation_info_.error = error;
+  ++called_back_count_;
+
+  if (waiting_ && (called_back_count_ > 0))
+    MessageLoopForUI::current()->Quit();
+}