Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(708)

Issue 9569042: Add reload item to default developer-mode platform app context menu. (Closed)

Created:
8 years, 9 months ago by jeremya
Modified:
8 years, 9 months ago
CC:
chromium-reviews, Avi (use Gerrit), creis+watch_chromium.org, brettw-cc_chromium.org, mihaip+watch_chromium.org, Aaron Boodman, ajwong+watch_chromium.org
Visibility:
Public.

Description

Add reload to default developer-mode platform app context menu. Without this, the only way to reload a platform app is to close the window and open it again, losing devtools context. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=125075

Patch Set 1 #

Total comments: 1

Patch Set 2 : fix EmptyContextMenu #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M chrome/browser/extensions/platform_app_browsertest.cc View 1 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/tab_contents/render_view_context_menu.cc View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
jeremya
benwells- you wrote this code :) brettw- chrome/browser/tab_contents owner mihaip- chrome/browser/extensions owner I added this ...
8 years, 9 months ago (2012-03-01 23:53:39 UTC) #1
benwells
lgtm with or without the change suggested, up to you. http://codereview.chromium.org/9569042/diff/1/chrome/browser/extensions/platform_app_browsertest.cc File chrome/browser/extensions/platform_app_browsertest.cc (right): http://codereview.chromium.org/9569042/diff/1/chrome/browser/extensions/platform_app_browsertest.cc#newcode138 ...
8 years, 9 months ago (2012-03-02 00:13:18 UTC) #2
Mihai Parparita -not on Chrome
LGTM
8 years, 9 months ago (2012-03-02 01:15:49 UTC) #3
brettw
lgtm
8 years, 9 months ago (2012-03-02 05:40:58 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jeremya@chromium.org/9569042/1
8 years, 9 months ago (2012-03-05 05:14:31 UTC) #5
commit-bot: I haz the power
Try job failure for 9569042-1 (retry) on linux_rel for step "browser_tests". It's a second try, ...
8 years, 9 months ago (2012-03-05 06:15:36 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jeremya@chromium.org/9569042/12001
8 years, 9 months ago (2012-03-06 00:22:08 UTC) #7
commit-bot: I haz the power
8 years, 9 months ago (2012-03-06 02:23:19 UTC) #8
Change committed as 125075

Powered by Google App Engine
This is Rietveld 408576698