Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1290)

Issue 9569025: Fix right-to-left script text truncation (Closed)

Created:
8 years, 9 months ago by xji
Modified:
8 years, 9 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina
Visibility:
Public.

Description

If script text is in right-to-left directionality, it got truncated because the width calculated in SizeStringInt() and DrawStringInt() are different since they are passed in different flags. DrawStringInt() was passed in an extra flag DT_RTLREADING through FORCE_RTL_DIRECTIONALITY. Fix by passing in the same flag for size calculation and drawing. BUG=104117 TEST=manual. JS alert a text begins with Hebrew letter followed by a punctuation, such as "A?". It should not be truncated. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=124736

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -16 lines) Patch
M ui/views/controls/label.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/label.cc View 5 chunks +18 lines, -15 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
xji
8 years, 9 months ago (2012-03-02 00:14:35 UTC) #1
sky
LGTM
8 years, 9 months ago (2012-03-02 00:22:41 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xji@chromium.org/9569025/1
8 years, 9 months ago (2012-03-02 19:36:27 UTC) #3
commit-bot: I haz the power
8 years, 9 months ago (2012-03-02 21:38:44 UTC) #4
Change committed as 124736

Powered by Google App Engine
This is Rietveld 408576698