Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(329)

Issue 9569012: Fixes the bug where the user is using a platform for which the Media Stream (Closed)

Created:
8 years, 9 months ago by macourteau
Modified:
8 years, 9 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Fix for the crash reported in bug 116174. Resolves the bug where the user is using a platform for which the Media Stream InfoBar is not implemented, and where he does not have the requested devices installed on his system (e.g., request for "Video" but the user has no camera). This fix applies to temporary code which will be removed whenever the InfoBar is implemented on all platforms. BUG=116174 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=124422

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M chrome/browser/chrome_content_browser_client.cc View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
macourteau
8 years, 9 months ago (2012-03-01 15:39:41 UTC) #1
Alexei Svitkine (slow)
LGTM http://codereview.chromium.org/9569012/diff/1/chrome/browser/chrome_content_browser_client.cc File chrome/browser/chrome_content_browser_client.cc (right): http://codereview.chromium.org/9569012/diff/1/chrome/browser/chrome_content_browser_client.cc#newcode1118 chrome/browser/chrome_content_browser_client.cc:1118: if (it->second.size() > 0) { Check !it->second.empty() instead. ...
8 years, 9 months ago (2012-03-01 15:48:23 UTC) #2
Alexei Svitkine (slow)
Also, please edit the CL (in the web UI) and make the title more meaningful. ...
8 years, 9 months ago (2012-03-01 15:49:38 UTC) #3
macourteau
http://codereview.chromium.org/9569012/diff/1/chrome/browser/chrome_content_browser_client.cc File chrome/browser/chrome_content_browser_client.cc (right): http://codereview.chromium.org/9569012/diff/1/chrome/browser/chrome_content_browser_client.cc#newcode1118 chrome/browser/chrome_content_browser_client.cc:1118: if (it->second.size() > 0) { On 2012/03/01 15:48:23, Alexei ...
8 years, 9 months ago (2012-03-01 15:52:21 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/macourteau@chromium.org/9569012/3002
8 years, 9 months ago (2012-03-01 15:52:58 UTC) #5
commit-bot: I haz the power
8 years, 9 months ago (2012-03-01 17:17:30 UTC) #6
Change committed as 124422

Powered by Google App Engine
This is Rietveld 408576698