Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3009)

Unified Diff: chrome/browser/ui/cocoa/download/download_item_mac.mm

Issue 9569011: Refactor dangerous download warning text generation into DownloadItemModel. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Kill some more code. Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/download/download_item_mac.mm
diff --git a/chrome/browser/ui/cocoa/download/download_item_mac.mm b/chrome/browser/ui/cocoa/download/download_item_mac.mm
index 832219692e07e711152143dffd2e7809cc421610..380e6c16548b66ecc79de6135ee50b305239bfda 100644
--- a/chrome/browser/ui/cocoa/download/download_item_mac.mm
+++ b/chrome/browser/ui/cocoa/download/download_item_mac.mm
@@ -30,8 +30,7 @@ DownloadItemMac::~DownloadItemMac() {
void DownloadItemMac::OnDownloadUpdated(content::DownloadItem* download) {
DCHECK_EQ(download, download_model_->download());
- if ([item_controller_ isDangerousMode] &&
- download->GetSafetyState() == DownloadItem::DANGEROUS_BUT_VALIDATED) {
+ if ([item_controller_ isDangerousMode] && !download_model_->IsDangerous()) {
// We have been approved.
[item_controller_ clearDangerousMode];
}

Powered by Google App Engine
This is Rietveld 408576698