Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 9568054: bluetooth: add function to hide Bluetooth settings (Closed)

Created:
8 years, 9 months ago by keybuk
Modified:
8 years, 9 months ago
Reviewers:
James Hawkins, kevers
CC:
chromium-reviews, arv (Not doing code reviews)
Visibility:
Public.

Description

bluetooth: add function to hide Bluetooth settings We support USB Bluetooth adapters being inserted and removed from our older Chromebooks, so as well as showing the Bluetooth settings on insertion we need a function to hide the settings pane again when the adapter is pulled out. BUG=chromium-os:27103 TEST=(with plumbing from later CL) removed adapter, verified the settings section vanished Change-Id: I1e820e4f660787e4f74c28761114459fc29352c5 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=124802

Patch Set 1 #

Total comments: 2

Patch Set 2 : fix nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M chrome/browser/resources/options2/browser_options.js View 1 2 chunks +9 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
keybuk
kevers for sanity check, jhawkins for OWNERS
8 years, 9 months ago (2012-03-02 03:04:28 UTC) #1
kevers
LGTM with nit. https://chromiumcodereview.appspot.com/9568054/diff/1/chrome/browser/resources/options2/browser_options.js File chrome/browser/resources/options2/browser_options.js (right): https://chromiumcodereview.appspot.com/9568054/diff/1/chrome/browser/resources/options2/browser_options.js#newcode1122 chrome/browser/resources/options2/browser_options.js:1122: * Dectivate the bluetooth settings section ...
8 years, 9 months ago (2012-03-02 14:59:42 UTC) #2
keybuk
https://chromiumcodereview.appspot.com/9568054/diff/1/chrome/browser/resources/options2/browser_options.js File chrome/browser/resources/options2/browser_options.js (right): https://chromiumcodereview.appspot.com/9568054/diff/1/chrome/browser/resources/options2/browser_options.js#newcode1122 chrome/browser/resources/options2/browser_options.js:1122: * Dectivate the bluetooth settings section from the System ...
8 years, 9 months ago (2012-03-02 15:54:10 UTC) #3
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
8 years, 9 months ago (2012-03-02 15:55:24 UTC) #4
James Hawkins
LGTM. I'm assuming the C++ side is already hooked up.
8 years, 9 months ago (2012-03-02 22:29:22 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/keybuk@chromium.org/9568054/5001
8 years, 9 months ago (2012-03-02 22:36:53 UTC) #6
commit-bot: I haz the power
8 years, 9 months ago (2012-03-03 01:06:36 UTC) #7
Change committed as 124802

Powered by Google App Engine
This is Rietveld 408576698