Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 9568044: chromeos: Remove user pod container height animation. (Closed)

Created:
8 years, 9 months ago by Daniel Erat
Modified:
8 years, 9 months ago
Reviewers:
Nikita (slow)
CC:
chromium-reviews, arv (Not doing code reviews), nkostylev+watch_chromium.org
Visibility:
Public.

Description

chromeos: Remove user pod container height animation. This removes an animation that adds a bit of jank at startup. It doesn't have a significant effect on boot time in either direction, from my measurements. BUG=chromium-os:26210 TEST=manual: booted and checked that animation is gone Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=124760

Patch Set 1 #

Total comments: 1

Patch Set 2 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M chrome/browser/resources/chromeos/login/oobe.css View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
Daniel Erat
8 years, 9 months ago (2012-03-01 23:41:11 UTC) #1
Nikita (slow)
lgtm Yes, removing this one makes sense. It adds jank on boot even on stumpy/lumpy. ...
8 years, 9 months ago (2012-03-02 16:22:06 UTC) #2
Daniel Erat
On 2012/03/02 16:22:06, Nikita Kostylev wrote: > lgtm > > Yes, removing this one makes ...
8 years, 9 months ago (2012-03-02 16:24:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/derat@chromium.org/9568044/4001
8 years, 9 months ago (2012-03-02 20:57:46 UTC) #4
commit-bot: I haz the power
Change committed as 124760
8 years, 9 months ago (2012-03-02 23:05:12 UTC) #5
Nikita (slow)
8 years, 9 months ago (2012-03-05 09:19:41 UTC) #6
Sorry, forgot to send out this one.
Never mind, per-file history is enough.

http://codereview.chromium.org/9568044/diff/1/chrome/browser/resources/chrome...
File chrome/browser/resources/chromeos/login/oobe.css (left):

http://codereview.chromium.org/9568044/diff/1/chrome/browser/resources/chrome...
chrome/browser/resources/chromeos/login/oobe.css:42: -webkit-transition: height
200ms ease-in-out;
Makes sense to comment that with a bug #(18307)?

Powered by Google App Engine
This is Rietveld 408576698