Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 9568014: Change the condition for disabling some tests. (Closed)

Created:
8 years, 9 months ago by Peter Mayo
Modified:
8 years, 9 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews, Paweł Hajdan Jr.
Visibility:
Public.

Description

Change the condition for disabling some tests. This more accurately reflects where they fail. There seem to be very few Google branded Chrome builds that aren't official, but this test fails for them. BUG=113399 TEST=Local passage.

Patch Set 1 #

Patch Set 2 : Rebase to current #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/common/logging_chrome_uitest.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Peter Mayo
History says you did this, still interested?
8 years, 9 months ago (2012-03-01 15:58:58 UTC) #1
Lei Zhang
LGTM
8 years, 9 months ago (2012-03-01 20:27:21 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/petermayo@chromium.org/9568014/3001
8 years, 9 months ago (2012-03-01 21:06:33 UTC) #3
commit-bot: I haz the power
8 years, 9 months ago (2012-03-01 23:02:27 UTC) #4
Change committed as 124519

Powered by Google App Engine
This is Rietveld 408576698