Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 9568013: Windows-only change. (Closed)

Created:
8 years, 9 months ago by enal
Modified:
8 years, 9 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Windows-only change. Blacklist sdhook32.dll that is part of "Spybot - Search & Destroy Live Protection". We'd seen the cases of crashes caused by that DLL. Looks that it modifies IAT of kernelbase.dll and then unloaded itself without unpatching IAT, causing delay load of ffmpeg to crash. Verified that blacklist really works. Installed version of ""Spybot - Search & Destroy" with "Live Protection" on my old XP machine, attached the debugger, and saw sdhook32.dll in all unmodified chrome processes. Copied Chrome with my changes to that machine, launched, and saw sdhook32.dll only in the browser, not in the renderer. BUG=110983 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=124687

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M content/common/sandbox_policy.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
enal1
Reviewers: Carlos as we discussed issue with him, and Darin as owner. Guys, can you ...
8 years, 9 months ago (2012-03-01 15:53:43 UTC) #1
darin (slow to review)
OWNERS LGTM, but please wait for LGTM from cpu
8 years, 9 months ago (2012-03-01 17:28:04 UTC) #2
cpu_(ooo_6.6-7.5)
lgtm
8 years, 9 months ago (2012-03-02 00:48:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/enal@chromium.org/9568013/1
8 years, 9 months ago (2012-03-02 02:35:55 UTC) #4
commit-bot: I haz the power
Try job failure for 9568013-1 (retry) on win_rel for step "check_deps". It's a second try, ...
8 years, 9 months ago (2012-03-02 05:39:39 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/enal@chromium.org/9568013/1
8 years, 9 months ago (2012-03-02 16:37:18 UTC) #6
commit-bot: I haz the power
8 years, 9 months ago (2012-03-02 18:16:53 UTC) #7
Change committed as 124687

Powered by Google App Engine
This is Rietveld 408576698