Added CPP wrapper for PPB_TCPServerSocket_Private.

ppapi/cpp/private/tcp_socket_private.cc

Index: ppapi/cpp/private/tcp_socket_private.cc
diff --git a/ppapi/cpp/private/tcp_socket_private.cc b/ppapi/cpp/private/tcp_socket_private.cc
index 9e2c1f6ac9136f4d919f288a3c9541fde950066b..5af22604212728a34f3e26b8edb7c26408c56541 100644
--- a/ppapi/cpp/private/tcp_socket_private.cc
+++ b/ppapi/cpp/private/tcp_socket_private.cc
@@ -28,6 +28,13 @@ TCPSocketPrivate::TCPSocketPrivate(const InstanceHandle& instance) {
   }
 }
 

[ygorshenin1, 2012/03/07 11:17:29]

I'm still afraid, that if PPB_TCPSocket_Private interface isn't available,
|resource| will leak. What we should do in that situation?

[yzshen1, 2012/03/07 17:27:05]

You could release it using ReleaseResource() in ppapi/cpp/core.h, and you could
get the core interface from the global module instance.

On 2012/03/07 11:17:29, ygorshenin1 wrote:

[ygorshenin1, 2012/03/07 17:40:40]

Sure, but how to notify user about that?

On 2012/03/07 17:27:05, yzshen1 wrote:

[yzshen1, 2012/03/07 17:56:49]

is_null() will be true.

If the user expects the resource to be a TCP socket while it isn't or the
interface is not available at all, losing the reference probably won't be too
bad.

On 2012/03/07 17:40:40, ygorshenin1 wrote:

[brettw, 2012/03/08 18:47:17]

I'd just delete the if and call the default resource constructor for PassRef.
This is what we do in e.g. FileRef.

So far, we haven't guaranteed that if the resource type is incorrect and you
pass it to the constructor that you'll get an is_null() resource. In this case,
you'll just get every function failing and an error in the console that the
object type is incorrect, which should be obvious enough.

We don't really expect user code to do this much, these constructors are more
for the C++ wrapper itself, since there's not much reason for the plugin to make
a bare PP_Resource and then want to make an object out of it. So I'm less
concerned about error checking this case, and I'm also worried about the leaking
problem Yuzhu mentioned.

[ygorshenin1, 2012/03/11 09:39:33]

Done.

+TCPSocketPrivate::TCPSocketPrivate(PassRef, PP_Resource resource) {
+  if (has_interface<PPB_TCPSocket_Private>() &&
+      get_interface<PPB_TCPSocket_Private>()->IsTCPSocket(resource)) {
+    PassRefFromConstructor(resource);
+  }
+}
+
 // static
 bool TCPSocketPrivate::IsAvailable() {
   return has_interface<PPB_TCPSocket_Private>();