Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3377)

Unified Diff: chrome/browser/ui/browser_close_browsertest.cc

Issue 9568003: Fixed issue with DownloadTestObserver. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fixed comment. Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/download/download_test_observer.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/browser_close_browsertest.cc
diff --git a/chrome/browser/ui/browser_close_browsertest.cc b/chrome/browser/ui/browser_close_browsertest.cc
index c0aacc690782137786b3c3194f06dac902f96ba4..5610a4f93103127521fe8a677f902a09fd771f07 100644
--- a/chrome/browser/ui/browser_close_browsertest.cc
+++ b/chrome/browser/ui/browser_close_browsertest.cc
@@ -115,13 +115,12 @@ class BrowserCloseTest : public InProcessBrowserTest {
DownloadManager* download_manager =
browser->profile()->GetDownloadManager();
scoped_ptr<DownloadTestObserver> observer(
- new DownloadTestObserver(
- download_manager, num_downloads,
- DownloadItem::IN_PROGRESS,
- true, // Bail on select file.
- DownloadTestObserver::ON_DANGEROUS_DOWNLOAD_FAIL));
+ new DownloadTestObserverInProgress(download_manager,
+ num_downloads,
+ true)); // Bail on select file.
// Set of that number of downloads.
+ size_t count_downloads = num_downloads;
while (num_downloads--)
ui_test_utils::NavigateToURLWithDisposition(
browser, url, NEW_BACKGROUND_TAB,
@@ -129,6 +128,8 @@ class BrowserCloseTest : public InProcessBrowserTest {
// Wait for them.
observer->WaitForFinished();
+ EXPECT_EQ(count_downloads,
+ observer->NumDownloadsSeenInState(DownloadItem::IN_PROGRESS));
}
// All all downloads created in CreateStalledDownloads() to
« no previous file with comments | « chrome/browser/download/download_test_observer.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698