Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2913)

Unified Diff: chrome/browser/ui/browser_close_browsertest.cc

Issue 9568003: Fixed issue with DownloadTestObserver. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Split DownloadTestObserver further. Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/browser_close_browsertest.cc
diff --git a/chrome/browser/ui/browser_close_browsertest.cc b/chrome/browser/ui/browser_close_browsertest.cc
index c0aacc690782137786b3c3194f06dac902f96ba4..ef9f08bd0d05cf1a6511e27af2407b3efd8c9c38 100644
--- a/chrome/browser/ui/browser_close_browsertest.cc
+++ b/chrome/browser/ui/browser_close_browsertest.cc
@@ -115,11 +115,7 @@ class BrowserCloseTest : public InProcessBrowserTest {
DownloadManager* download_manager =
browser->profile()->GetDownloadManager();
scoped_ptr<DownloadTestObserver> observer(
- new DownloadTestObserver(
- download_manager, num_downloads,
- DownloadItem::IN_PROGRESS,
- true, // Bail on select file.
- DownloadTestObserver::ON_DANGEROUS_DOWNLOAD_FAIL));
+ new DownloadTestObserverInProgress(download_manager, num_downloads));
// Set of that number of downloads.
while (num_downloads--)
@@ -129,6 +125,7 @@ class BrowserCloseTest : public InProcessBrowserTest {
// Wait for them.
observer->WaitForFinished();
+ DCHECK_EQ(1u, observer->NumDownloadsSeenInState(DownloadItem::IN_PROGRESS));
Randy Smith (Not in Mondays) 2012/03/08 18:25:31 Why is this 1 rather than the value num_downloads
ahendrickson 2012/03/08 20:56:34 Cut & paste error. Fixed.
}
// All all downloads created in CreateStalledDownloads() to

Powered by Google App Engine
This is Rietveld 408576698