Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(349)

Issue 9568001: Use URLFetcher to download ChromeOS recovery image config file (Closed)

Created:
8 years, 9 months ago by hashimoto
Modified:
8 years, 9 months ago
Reviewers:
tbarzic
CC:
chromium-reviews, achuith+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org, tbarzic+watch_chromium.org
Visibility:
Public.

Description

Use URLFetcher to download ChromeOS recovery image config file Initialization of BurnManager is deferred since it depends on IO thread through BrowserProcess::system_request_context. BUG=113469 TEST=Open chrome://imageburner on a Chromebook, ensure it works. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=124638

Patch Set 1 : _ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -118 lines) Patch
M chrome/browser/chromeos/chrome_browser_main_chromeos.cc View 4 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/imageburner/burn_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/imageburner/burn_manager.h View 4 chunks +18 lines, -27 lines 0 comments Download
M chrome/browser/chromeos/imageburner/burn_manager.cc View 7 chunks +25 lines, -88 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
hashimoto
8 years, 9 months ago (2012-03-01 11:42:30 UTC) #1
tbarzic
On 2012/03/01 11:42:30, hashimoto wrote: lgtm
8 years, 9 months ago (2012-03-01 20:00:55 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/9568001/8
8 years, 9 months ago (2012-03-02 03:53:44 UTC) #3
commit-bot: I haz the power
8 years, 9 months ago (2012-03-02 15:00:40 UTC) #4
Change committed as 124638

Powered by Google App Engine
This is Rietveld 408576698