Adding some stubs for some InfoBars on Android.

Adding some stubs for some InfoBars on Android.

InfoBars on Android are implemented in Java and only use InfoBarDelegates,
not actual InfoBars.
We still need stubs for the infobars so we can link the sync unit-tests.

BUG=None
TEST=None


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=125091

[Elliot Glaysher, 2012-03-02 18:03:57]

lgtm

[Peter Kasting, 2012-03-02 18:05:41]

Can we change the sync unit tests in some way so that you don't need these?

[Jay Civelli, 2012-03-02 19:44:38]

On 2012/03/02 18:05:41, Peter Kasting wrote:
> Can we change the sync unit tests in some way so that you don't need these?

sync_unit_tests depend on the browser target (though test_support_common).
It would be hard to remove that dependency.

[Peter Kasting, 2012-03-02 21:28:56]

On 2012/03/02 19:44:38, Jay Civelli wrote:
> On 2012/03/02 18:05:41, Peter Kasting wrote:
> > Can we change the sync unit tests in some way so that you don't need these?
> 
> sync_unit_tests depend on the browser target (though test_support_common).
> It would be hard to remove that dependency.

Do you need to remove it?  I was just assuming you had actual sync tests trying
to call these functions.

It sounds like maybe the story is that browser calls all these, and no other
Android projects use browser except the sync tests?  If that's true maybe
breaking this dependency is worthwhile.  We could probably split
test_support_common into a couple pieces.

If OTOH this is just one of dozens of projects that will depend on browser and
so you'll need this lots of other places anyway, then never mind.

[Jay Civelli, 2012-03-02 22:18:45]

On 2012/03/02 21:28:56, Peter Kasting wrote:
> On 2012/03/02 19:44:38, Jay Civelli wrote:
> > On 2012/03/02 18:05:41, Peter Kasting wrote:
> > > Can we change the sync unit tests in some way so that you don't need
these?
> > 
> > sync_unit_tests depend on the browser target (though test_support_common).
> > It would be hard to remove that dependency.
> 
> Do you need to remove it?  I was just assuming you had actual sync tests
trying
> to call these functions.
> 
> It sounds like maybe the story is that browser calls all these, and no other
> Android projects use browser except the sync tests?  If that's true maybe
> breaking this dependency is worthwhile.  We could probably split
> test_support_common into a couple pieces.
> 
> If OTOH this is just one of dozens of projects that will depend on browser and
> so you'll need this lots of other places anyway, then never mind.
Yeah, we have several other test projects that we'd like to build that depend on
browser also. So I'll go with the stubs for now.

[commit-bot: I haz the power, 2012-03-05 19:02:39]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jcivelli@chromium.org/9567039/1

[commit-bot: I haz the power, 2012-03-05 19:02:41]

Presubmit check for 9567039-1 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for: chrome/browser/ui/android/infobar_stubs.cc

Was the presubmit check useful? Please send feedback & hate mail to
maruel@chromium.org!

[Jay Civelli, 2012-03-05 19:12:06]

Peter,
Could I get a LGTM from you so I can land?

Thanks.

[Peter Kasting, 2012-03-05 22:15:52]

LGTM

[commit-bot: I haz the power, 2012-03-05 22:25:31]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jcivelli@chromium.org/9567039/1

[commit-bot: I haz the power, 2012-03-06 03:26:05]

Change committed as 125091