Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(511)

Unified Diff: remoting/protocol/session.h

Issue 9567033: Cleanup error handling in the client plugin. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: - Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « remoting/protocol/protocol_mock_objects.h ('k') | remoting/remoting.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/protocol/session.h
diff --git a/remoting/protocol/session.h b/remoting/protocol/session.h
index 7749afa0d491de2d55525cf17fb33eca6efb2653..6e3ac356a18b0145e03b2b97ed0ea3af2a688789 100644
--- a/remoting/protocol/session.h
+++ b/remoting/protocol/session.h
@@ -10,6 +10,7 @@
#include "base/callback.h"
#include "base/threading/non_thread_safe.h"
#include "remoting/protocol/buffered_socket_writer.h"
+#include "remoting/protocol/errors.h"
#include "remoting/protocol/session_config.h"
namespace net {
@@ -53,17 +54,6 @@ class Session : public base::NonThreadSafe {
FAILED,
};
- // TODO(sergeyu): Move error codes to a separate file.
- enum Error {
- OK = 0,
- PEER_IS_OFFLINE,
- SESSION_REJECTED,
- INCOMPATIBLE_PROTOCOL,
- AUTHENTICATION_FAILED,
- CHANNEL_CONNECTION_ERROR,
- UNKNOWN_ERROR,
- };
-
// State change callbacks are called after session state has
// changed. It is not safe to destroy the session from within the
// handler unless |state| is CLOSED or FAILED.
@@ -95,7 +85,7 @@ class Session : public base::NonThreadSafe {
virtual void SetRouteChangeCallback(const RouteChangeCallback& callback) = 0;
// Returns error code for a failed session.
- virtual Error error() = 0;
+ virtual ErrorCode error() = 0;
// Creates new channels for this connection. The specified callback
// is called when then new channel is created and connected. The
« no previous file with comments | « remoting/protocol/protocol_mock_objects.h ('k') | remoting/remoting.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698