Fix and re-enable IndexedDBBrowserTestWithLowQuota.QuotaTest

Fix and re-enable IndexedDBBrowserTestWithLowQuota.QuotaTest

There were two problems.
1) We had started to write into profile/IndexedDB/IndexedDB/origin.leveldb/ (note the double IndexedDB).
2) We were writing into file__0.leveldb but checking for quota in __0.leveldb.  Now we always use __0.leveldb.

BUG=104748
TEST=


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=124782

[dgrogan, 2012-03-01 23:48:55]

Josh, can you review when you get a chance?

[jsbell, 2012-03-02 00:51:31]

lgtm with nits

https://chromiumcodereview.appspot.com/9567030/diff/2001/content/browser/in_p...
File content/browser/in_process_webkit/indexed_db_browsertest.cc (right):

https://chromiumcodereview.appspot.com/9567030/diff/2001/content/browser/in_p...
content/browser/in_process_webkit/indexed_db_browsertest.cc:336: // No longer
testable with file: URL: http://crbug.com/104748
Remove this comment

https://chromiumcodereview.appspot.com/9567030/diff/2001/content/browser/in_p...
File content/browser/in_process_webkit/indexed_db_dispatcher_host.cc (right):

https://chromiumcodereview.appspot.com/9567030/diff/2001/content/browser/in_p...
content/browser/in_process_webkit/indexed_db_dispatcher_host.cc:227: GURL
origin_url = DatabaseUtil::GetOriginFromIdentifier(params.origin);
Maybe file a crbug to move this from database_util to something more generic. It
looks like filesystem_util has an identical copy.

[dgrogan, 2012-03-02 01:23:54]

Michael, could you review as owner of webkit/fileapi ?

https://chromiumcodereview.appspot.com/9567030/diff/2001/content/browser/in_p...
File content/browser/in_process_webkit/indexed_db_browsertest.cc (right):

https://chromiumcodereview.appspot.com/9567030/diff/2001/content/browser/in_p...
content/browser/in_process_webkit/indexed_db_browsertest.cc:336: // No longer
testable with file: URL: http://crbug.com/104748
On 2012/03/02 00:51:31, jsbell wrote:
> Remove this comment

Done.

https://chromiumcodereview.appspot.com/9567030/diff/2001/content/browser/in_p...
File content/browser/in_process_webkit/indexed_db_dispatcher_host.cc (right):

https://chromiumcodereview.appspot.com/9567030/diff/2001/content/browser/in_p...
content/browser/in_process_webkit/indexed_db_dispatcher_host.cc:227: GURL
origin_url = DatabaseUtil::GetOriginFromIdentifier(params.origin);
On 2012/03/02 00:51:31, jsbell wrote:
> Maybe file a crbug to move this from database_util to something more generic.
It
> looks like filesystem_util has an identical copy.

Done.

[michaeln, 2012-03-02 04:43:20]

it's fine by me to commit comment-only changes in here w/o owner review within
reasonable limits, this one is well within those limits :)

But I have a question about the idb path mixup? In the shipping version of
chrome, where are the database files? Does this CL agree or disagree with that
location?

[dgrogan, 2012-03-02 21:08:08]

On 2012/03/02 04:43:20, michaeln wrote:
> it's fine by me to commit comment-only changes in here w/o owner review within
> reasonable limits, this one is well within those limits :)

Yeah, it's a bummer that the commit queue isn't ok with that as well.  Though I
didn't try it, just assumed that it would be strict.

> But I have a question about the idb path mixup? In the shipping version of
> chrome, where are the database files? Does this CL agree or disagree with that
> location?

This CL agrees with it, it's just the last few days' dev release which uses the
double IndexedDB directory.

[commit-bot: I haz the power, 2012-03-02 21:28:29]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dgrogan@chromium.org/9567030/5003

[commit-bot: I haz the power, 2012-03-02 21:28:33]

Presubmit check for 9567030-5003 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit Messages **
If this change requires manual test instructions to QA team, add
TEST=[instructions].

** Presubmit ERRORS **
Missing LGTM from an OWNER for: webkit/fileapi/file_system_util.cc

Presubmit checks took 1.3s to calculate.

[dgrogan, 2012-03-02 21:29:18]

Yep, the c-q is strict about OWNERS for small comment changes.

[michaeln, 2012-03-02 21:56:19]

lgtm, thnx for explaining scope of the path mixup

[commit-bot: I haz the power, 2012-03-02 21:57:24]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dgrogan@chromium.org/9567030/5003

[commit-bot: I haz the power, 2012-03-02 23:59:06]

Change committed as 124782