Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1513)

Unified Diff: content/common/gpu/gpu_channel.cc

Issue 9567028: Make echo message per-command-buffer (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/common/gpu/gpu_channel.h ('k') | content/common/gpu/gpu_command_buffer_stub.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/common/gpu/gpu_channel.cc
diff --git a/content/common/gpu/gpu_channel.cc b/content/common/gpu/gpu_channel.cc
index 4eb31297675633460dbea22856751cdb5bc6de26..daa0910e826073f8a9cab3e0d3f0a510cef3d282 100644
--- a/content/common/gpu/gpu_channel.cc
+++ b/content/common/gpu/gpu_channel.cc
@@ -73,10 +73,8 @@ bool GpuChannel::OnMessageReceived(const IPC::Message& message) {
}
// Control messages are not deferred and can be handled out of order with
- // respect to routed ones. Except for Echo, which must be deferred in order
- // to respect the asynchronous Mac SwapBuffers.
- if (message.routing_id() == MSG_ROUTING_CONTROL &&
- message.type() != GpuChannelMsg_Echo::ID)
+ // respect to routed ones.
+ if (message.routing_id() == MSG_ROUTING_CONTROL)
return OnControlMessageReceived(message);
if (message.type() == GpuCommandBufferMsg_GetStateFast::ID) {
@@ -229,7 +227,6 @@ bool GpuChannel::OnControlMessageReceived(const IPC::Message& msg) {
OnCreateOffscreenCommandBuffer)
IPC_MESSAGE_HANDLER_DELAY_REPLY(GpuChannelMsg_DestroyCommandBuffer,
OnDestroyCommandBuffer)
- IPC_MESSAGE_HANDLER(GpuChannelMsg_Echo, OnEcho);
IPC_MESSAGE_HANDLER_DELAY_REPLY(GpuChannelMsg_WillGpuSwitchOccur,
OnWillGpuSwitchOccur)
IPC_MESSAGE_HANDLER(GpuChannelMsg_CloseChannel, OnCloseChannel)
@@ -250,9 +247,7 @@ void GpuChannel::HandleMessage() {
processed_get_state_fast_ =
(message->type() == GpuCommandBufferMsg_GetStateFast::ID);
// Handle deferred control messages.
- if (message->routing_id() == MSG_ROUTING_CONTROL)
- OnControlMessageReceived(*message);
- else if (!router_.RouteMessage(*message)) {
+ if (!router_.RouteMessage(*message)) {
// Respond to sync messages even if router failed to route.
if (message->is_sync()) {
IPC::Message* reply = IPC::SyncMessage::GenerateReply(&*message);
@@ -374,10 +369,6 @@ void GpuChannel::OnDestroyCommandBuffer(int32 route_id,
Send(reply_message);
}
-void GpuChannel::OnEcho(const IPC::Message& message) {
- TRACE_EVENT0("gpu", "GpuCommandBufferStub::OnEcho");
- Send(new IPC::Message(message));
-}
void GpuChannel::OnWillGpuSwitchOccur(bool is_creating_context,
gfx::GpuPreference gpu_preference,
« no previous file with comments | « content/common/gpu/gpu_channel.h ('k') | content/common/gpu/gpu_command_buffer_stub.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698