Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Issue 9567017: Prefix Android-string descriptions with Mobile: (Closed)

Created:
8 years, 9 months ago by nyquist
Modified:
8 years, 9 months ago
Reviewers:
TVL
CC:
chromium-reviews
Visibility:
Public.

Description

Prefix Android-string descriptions with Mobile: Some strings currently have a specific version for Android, but the description attribute does not mention this. This prefixes "Mobile: " for all Android strings where the same message name is already in use, and Android just has a specific version of a string for mobile. BUG=114046 TEST=Verify that strings show up correctly in Android build. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=124589

Patch Set 1 #

Total comments: 3

Patch Set 2 : Removed wrong use of 'In Title Case' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -49 lines) Patch
M chrome/app/generated_resources.grd View 1 41 chunks +49 lines, -49 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
nyquist
Changes desc: to be prefixed with "Mobile: " for when Android duplicates a string, but ...
8 years, 9 months ago (2012-03-01 19:44:40 UTC) #1
TVL
lgtm lg with the one error fix. https://chromiumcodereview.appspot.com/9567017/diff/1/chrome/app/generated_resources.grd File chrome/app/generated_resources.grd (right): https://chromiumcodereview.appspot.com/9567017/diff/1/chrome/app/generated_resources.grd#newcode1114 chrome/app/generated_resources.grd:1114: <message name="IDS_SHOW_BOOKMARK_BAR" ...
8 years, 9 months ago (2012-03-01 20:14:44 UTC) #2
nyquist
remove wrong use of title case description https://chromiumcodereview.appspot.com/9567017/diff/1/chrome/app/generated_resources.grd File chrome/app/generated_resources.grd (right): https://chromiumcodereview.appspot.com/9567017/diff/1/chrome/app/generated_resources.grd#newcode1114 chrome/app/generated_resources.grd:1114: <message name="IDS_SHOW_BOOKMARK_BAR" ...
8 years, 9 months ago (2012-03-01 21:37:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nyquist@chromium.org/9567017/4001
8 years, 9 months ago (2012-03-01 22:54:31 UTC) #4
commit-bot: I haz the power
8 years, 9 months ago (2012-03-02 04:00:16 UTC) #5
Change committed as 124589

Powered by Google App Engine
This is Rietveld 408576698