Issue 9566046: Add about:flags flag for the Suggestions NTP.

Issue 9566046: Add about:flags flag for the Suggestions NTP. (Closed)

Created:
8 years, 9 months ago by GeorgeY

Modified:
8 years, 9 months ago

Reviewers:
Ilya Sherman

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Add about:flags flag for the Suggestions NTP. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=124780

Patch Set 2 : Addressed comments #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -0 lines)			Patch
	M	chrome/app/generated_resources.grd	View	1	1 chunk	+6 lines, -0 lines	0 comments	Download
	M	chrome/browser/about_flags.cc	View	1	1 chunk	+7 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Ilya Sherman

LGTM, feel free to change things per my suggestions or to ignore 'em. https://chromiumcodereview.appspot.com/9566046/diff/1/chrome/app/generated_resources.grd File ...

8 years, 9 months ago (2012-03-02 18:27:34 UTC) #2

GeorgeY

done https://chromiumcodereview.appspot.com/9566046/diff/1/chrome/app/generated_resources.grd File chrome/app/generated_resources.grd (right): https://chromiumcodereview.appspot.com/9566046/diff/1/chrome/app/generated_resources.grd#newcode4948 chrome/app/generated_resources.grd:4948: <message name="IDS_FLAGS_SUGGESTIONS_PAGE_NAME" desc="Name of the 'Enable suggestions page' ...

8 years, 9 months ago (2012-03-02 19:55:50 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/georgey@chromium.org/9566046/3001

8 years, 9 months ago (2012-03-02 19:56:36 UTC) #4

Change committed as 124780

Expand Messages | Collapse Messages