Expose compositor filters on ui::Layer.

Expose compositor filters on ui::Layer.

BUG=118067
TEST=

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=133497

[Ben Goodger (Google), 2012-04-17 22:17:57]

I notice you're adding WebKit:: types directly to the API here. I think this is
something we've avoided so far. It keeps the Chrome codebase free of WebKit::
(see ui::Transform, gfx::Rect, etc). piman, any opinions on this?

[piman, 2012-04-17 22:25:34]

On 2012/04/17 22:17:57, Ben Goodger (Google) wrote:
> I notice you're adding WebKit:: types directly to the API here. I think this
is
> something we've avoided so far. It keeps the Chrome codebase free of WebKit::
> (see ui::Transform, gfx::Rect, etc). piman, any opinions on this?

Absolutely, I said essentially the same thing, or thought I did, but somehow it
didn't go through.

[danakj, 2012-04-17 22:26:34]

On 2012/04/17 22:25:34, piman wrote:
> On 2012/04/17 22:17:57, Ben Goodger (Google) wrote:
> > I notice you're adding WebKit:: types directly to the API here. I think this
> is
> > something we've avoided so far. It keeps the Chrome codebase free of
WebKit::
> > (see ui::Transform, gfx::Rect, etc). piman, any opinions on this?
> 
> Absolutely, I said essentially the same thing, or thought I did, but somehow
it
> didn't go through.

Does this imply three copies of the FilterOperations class hierarchy? :(

Or do you just want something like "setBackgroundBlur(5px)" on ui::Layer?

[piman, 2012-04-17 23:09:34]

On 2012/04/17 22:26:34, danakj wrote:
> On 2012/04/17 22:25:34, piman wrote:
> > On 2012/04/17 22:17:57, Ben Goodger (Google) wrote:
> > > I notice you're adding WebKit:: types directly to the API here. I think
this
> > is
> > > something we've avoided so far. It keeps the Chrome codebase free of
> WebKit::
> > > (see ui::Transform, gfx::Rect, etc). piman, any opinions on this?
> > 
> > Absolutely, I said essentially the same thing, or thought I did, but somehow
> it
> > didn't go through.
> 
> Does this imply three copies of the FilterOperations class hierarchy? :(
> 
> Or do you just want something like "setBackgroundBlur(5px)" on ui::Layer?

I think it's ok to expose what the UI needs, as opposed to all of WebKit.

[danakj, 2012-04-20 23:07:04]

On 2012/04/17 23:09:34, piman wrote:
> I think it's ok to expose what the UI needs, as opposed to all of WebKit.

Ok! Just exposing a simple API to set a background blur radius.

[piman, 2012-04-21 00:11:10]

lgtm

[commit-bot: I haz the power, 2012-04-23 18:14:04]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/danakj@chromium.org/9566036/8002

[commit-bot: I haz the power, 2012-04-23 19:37:21]

Change committed as 133497