Issue 9566035: Move QuotaPermissionContext to content/public/browser and put it in the content namespace.

Issue 9566035: Move QuotaPermissionContext to content/public/browser and put it in the content namespace. (Closed)

Created:
8 years, 9 months ago by tfarina

Modified:
8 years, 9 months ago

Reviewers:
jam

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Move QuotaPermissionContext to content/public/browser and put it in the content namespace. BUG=98716 R=jam@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=124710

Patch Set 3 : fix #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+103 lines, -131 lines)			Patch
M	chrome/browser/DEPS	View	1 2	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/chrome_content_browser_client.h	View		2 chunks	+6 lines, -1 line	0 comments	Download
M	chrome/browser/chrome_content_browser_client.cc	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/chrome_quota_permission_context.h	View	1 2	3 chunks	+4 lines, -4 lines	0 comments	Download
M	chrome/browser/chrome_quota_permission_context.cc	View	1 2	7 chunks	+12 lines, -7 lines	0 comments	Download
M	content/browser/mock_content_browser_client.h	View		6 chunks	+16 lines, -18 lines	0 comments	Download
M	content/browser/mock_content_browser_client.cc	View		10 chunks	+25 lines, -28 lines	0 comments	Download
D	content/browser/quota_permission_context.h	View		1 chunk	+0 lines, -39 lines	0 comments	Download
M	content/browser/renderer_host/quota_dispatcher_host.h	View		4 chunks	+7 lines, -5 lines	0 comments	Download
M	content/browser/renderer_host/quota_dispatcher_host.cc	View	1	3 chunks	+6 lines, -4 lines	0 comments	Download
M	content/content_browser.gypi	View		2 chunks	+1 line, -1 line	0 comments	Download
M	content/public/browser/content_browser_client.h	View	1	2 chunks	+10 lines, -13 lines	0 comments	Download
A +	content/public/browser/quota_permission_context.h	View	1 2	3 chunks	+15 lines, -10 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

jam

lgtm with nit http://codereview.chromium.org/9566035/diff/7013/content/public/browser/quota_permission_context.h File content/public/browser/quota_permission_context.h (right): http://codereview.chromium.org/9566035/diff/7013/content/public/browser/quota_permission_context.h#newcode20 content/public/browser/quota_permission_context.h:20: enum Response { nit: for the ...

8 years, 9 months ago (2012-03-02 00:12:39 UTC) #2

tfarina

http://codereview.chromium.org/9566035/diff/7013/content/public/browser/quota_permission_context.h File content/public/browser/quota_permission_context.h (right): http://codereview.chromium.org/9566035/diff/7013/content/public/browser/quota_permission_context.h#newcode20 content/public/browser/quota_permission_context.h:20: enum Response { On 2012/03/02 00:12:39, John Abd-El-Malek wrote: ...

8 years, 9 months ago (2012-03-02 00:23:29 UTC) #3

slgtm

thanks for doing this

Expand Messages | Collapse Messages