Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(242)

Issue 9566018: chromeos: use the correct proxy for Chromium signals (Closed)

Created:
8 years, 9 months ago by keybuk
Modified:
8 years, 9 months ago
CC:
chromium-reviews, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

chromeos: use the correct proxy for Chromium signals The power manager client receives signals from the session manager, which uses a different path for those signals. Create a proxy for that object as well so we receive them, they were only receiving them before because of a bug where the first object proxy would get all signal messages. BUG=chromium-os:27146 TEST=desktopui_ScreenLocker failed before, passes now Change-Id: I4a8193d94e9a114d32aac79577b35a69043cbcf0 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=124568

Patch Set 1 #

Patch Set 2 : more correct fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -3 lines) Patch
M chrome/browser/chromeos/dbus/power_manager_client.cc View 1 4 chunks +8 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
keybuk
8 years, 9 months ago (2012-03-01 19:28:16 UTC) #1
satorux1
Cannot we fix the login manager instead? Sending a signal from '/' doesn't sound right ...
8 years, 9 months ago (2012-03-01 19:32:52 UTC) #2
keybuk
looking into that option now - this was a "quick fix" to pass the test ...
8 years, 9 months ago (2012-03-01 19:37:30 UTC) #3
satorux1
I'm ok with the "quick fix" if the other option turned out to be difficult. ...
8 years, 9 months ago (2012-03-01 19:40:02 UTC) #4
keybuk
ok, here's a proper fix that relies on the fix in https://gerrit.chromium.org/gerrit/17171
8 years, 9 months ago (2012-03-01 20:48:43 UTC) #5
flackr
lgtm
8 years, 9 months ago (2012-03-01 21:59:16 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/keybuk@chromium.org/9566018/6001
8 years, 9 months ago (2012-03-01 22:07:33 UTC) #7
satorux1
LGTM. Thanks.
8 years, 9 months ago (2012-03-01 22:17:34 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/keybuk@chromium.org/9566018/6001
8 years, 9 months ago (2012-03-01 22:28:31 UTC) #9
commit-bot: I haz the power
8 years, 9 months ago (2012-03-02 02:02:44 UTC) #10
Change committed as 124568

Powered by Google App Engine
This is Rietveld 408576698