Issue 9565050: [Sync] Simplify GetSessionName interface

Issue 9565050: [Sync] Simplify GetSessionName interface (Closed)

Created:
8 years, 9 months ago by akalin

Modified:
8 years, 9 months ago

Reviewers:
Nicolas Zea

CC:
chromium-reviews, Raghu Simha, ncarter (slow), akalin, tim (not reviewing)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[Sync] Simplify GetSessionName interface Turn the GetSessionNameTask class into a simple GetSessionName function. Use the browser thread blocking pool instead of the FILE thread. Remove dependency on BrowserThread from internal_api. BUG=113723 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=124838

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix compile errors, address comments #

Patch Set 3 : fix win compile failure #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+158 lines, -277 lines)			Patch
M	chrome/browser/sync/glue/session_model_associator.cc	View		3 chunks	+4 lines, -6 lines	0 comments	Download
M	chrome/browser/sync/glue/sync_backend_host.cc	View		2 chunks	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/sync/internal_api/DEPS	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/sync/internal_api/sync_manager.h	View		3 chunks	+5 lines, -0 lines	0 comments	Download
M	chrome/browser/sync/internal_api/sync_manager.cc	View		8 chunks	+14 lines, -9 lines	0 comments	Download
M	chrome/browser/sync/internal_api/syncapi_unittest.cc	View	1	16 chunks	+5 lines, -43 lines	0 comments	Download
A	chrome/browser/sync/util/get_session_name.h	View		1 chunk	+39 lines, -0 lines	0 comments	Download
A	chrome/browser/sync/util/get_session_name.cc	View	1 2	1 chunk	+76 lines, -0 lines	0 comments	Download
A +	chrome/browser/sync/util/get_session_name_mac.mm	View		3 chunks	+5 lines, -4 lines	0 comments	Download
D	chrome/browser/sync/util/get_session_name_task.h	View		1 chunk	+0 lines, -62 lines	0 comments	Download
D	chrome/browser/sync/util/get_session_name_task.cc	View		1 chunk	+0 lines, -65 lines	0 comments	Download
D	chrome/browser/sync/util/get_session_name_task_mac.mm	View		1 chunk	+0 lines, -50 lines	0 comments	Download
D	chrome/browser/sync/util/get_session_name_task_unittest.cc	View		1 chunk	+0 lines, -31 lines	0 comments	Download
A +	chrome/browser/sync/util/get_session_name_unittest.cc	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/chrome.gyp	View		1 chunk	+3 lines, -3 lines	0 comments	Download
M	chrome/chrome_tests.gypi	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

Nicolas Zea

lgtm http://codereview.chromium.org/9565050/diff/1/chrome/browser/sync/internal_api/syncapi_unittest.cc File chrome/browser/sync/internal_api/syncapi_unittest.cc (right): http://codereview.chromium.org/9565050/diff/1/chrome/browser/sync/internal_api/syncapi_unittest.cc#newcode913 chrome/browser/sync/internal_api/syncapi_unittest.cc:913: MessageLoop ui_loop_; may as well rename this to ...

8 years, 9 months ago (2012-03-02 21:05:26 UTC) #2

akalin

checking in as soon as trybots pass http://codereview.chromium.org/9565050/diff/1/chrome/browser/sync/internal_api/syncapi_unittest.cc File chrome/browser/sync/internal_api/syncapi_unittest.cc (right): http://codereview.chromium.org/9565050/diff/1/chrome/browser/sync/internal_api/syncapi_unittest.cc#newcode913 chrome/browser/sync/internal_api/syncapi_unittest.cc:913: MessageLoop ui_loop_; ...

8 years, 9 months ago (2012-03-02 23:02:41 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/akalin@chromium.org/9565050/9001

8 years, 9 months ago (2012-03-02 23:03:07 UTC) #4

commit-bot: I haz the power

Try job failure for 9565050-9001 (retry) on win_rel for step "compile" (clobber build). It's a ...

8 years, 9 months ago (2012-03-03 00:05:29 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/akalin@chromium.org/9565050/6004

8 years, 9 months ago (2012-03-03 01:45:53 UTC) #6

Change committed as 124838

Expand Messages | Collapse Messages