Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(354)

Issue 9565042: Remove obsolete code (Closed)

Created:
8 years, 9 months ago by oshima
Modified:
8 years, 9 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -13 lines) Patch
M chrome/browser/ui/views/tab_contents/tab_contents_view_views.h View 1 2 chunks +0 lines, -6 lines 0 comments Download
M chrome/browser/ui/views/tab_contents/tab_contents_view_views.cc View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
oshima
8 years, 9 months ago (2012-03-02 01:33:59 UTC) #1
jam
thanks for getting to this quickly is the ContainingView() stuff in constrained_window_gtk still needed?
8 years, 9 months ago (2012-03-02 01:44:07 UTC) #2
oshima
On Thu, Mar 1, 2012 at 5:44 PM, <jam@chromium.org> wrote: > thanks for getting to ...
8 years, 9 months ago (2012-03-02 01:59:52 UTC) #3
jam
On 2012/03/02 01:59:52, oshima wrote: > On Thu, Mar 1, 2012 at 5:44 PM, <mailto:jam@chromium.org> ...
8 years, 9 months ago (2012-03-02 02:06:15 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/9565042/1003
8 years, 9 months ago (2012-03-02 02:19:04 UTC) #5
commit-bot: I haz the power
Presubmit check for 9565042-1003 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 9 months ago (2012-03-02 02:19:07 UTC) #6
oshima
Ben can you approve this?
8 years, 9 months ago (2012-03-02 02:35:12 UTC) #7
Ben Goodger (Google)
lgtm
8 years, 9 months ago (2012-03-02 04:35:35 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/9565042/1003
8 years, 9 months ago (2012-03-02 04:46:19 UTC) #9
commit-bot: I haz the power
8 years, 9 months ago (2012-03-02 15:04:49 UTC) #10
Change committed as 124641

Powered by Google App Engine
This is Rietveld 408576698