Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 9565041: Cleanup: Typedef std::pairs in TaskManager code. (Closed)

Created:
8 years, 9 months ago by Lei Zhang
Modified:
8 years, 9 months ago
CC:
chromium-reviews, yoshiki+watch_chromium.org
Visibility:
Public.

Description

Cleanup: Typedef std::pairs in TaskManager code. Also making goat teleporting thread safe! BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=124662

Patch Set 1 : #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -32 lines) Patch
M chrome/browser/task_manager/task_manager.h View 1 7 chunks +11 lines, -7 lines 0 comments Download
M chrome/browser/task_manager/task_manager.cc View 8 chunks +10 lines, -10 lines 0 comments Download
M chrome/browser/ui/cocoa/task_manager_mac.mm View 3 chunks +6 lines, -4 lines 0 comments Download
M chrome/browser/ui/gtk/task_manager_gtk.cc View 3 chunks +6 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/task_manager_view.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/task_manager_handler.cc View 4 chunks +4 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Lei Zhang
8 years, 9 months ago (2012-03-02 01:32:19 UTC) #1
Ben Goodger (Google)
lgtm
8 years, 9 months ago (2012-03-02 04:36:50 UTC) #2
yoshiki
https://chromiumcodereview.appspot.com/9565041/diff/9/chrome/browser/task_manager/task_manager.h File chrome/browser/task_manager/task_manager.h (right): https://chromiumcodereview.appspot.com/9565041/diff/9/chrome/browser/task_manager/task_manager.h#newcode458 chrome/browser/task_manager/task_manager.h:458: typedef std::map<base::ProcessHandle, MemoryUsageEntry > MemoryUsageMap; nit: please remove the ...
8 years, 9 months ago (2012-03-02 04:38:39 UTC) #3
Lei Zhang
https://chromiumcodereview.appspot.com/9565041/diff/9/chrome/browser/task_manager/task_manager.h File chrome/browser/task_manager/task_manager.h (right): https://chromiumcodereview.appspot.com/9565041/diff/9/chrome/browser/task_manager/task_manager.h#newcode458 chrome/browser/task_manager/task_manager.h:458: typedef std::map<base::ProcessHandle, MemoryUsageEntry > MemoryUsageMap; On 2012/03/02 04:38:39, yoshiki ...
8 years, 9 months ago (2012-03-02 04:39:36 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/9565041/3004
8 years, 9 months ago (2012-03-02 04:39:46 UTC) #5
commit-bot: I haz the power
8 years, 9 months ago (2012-03-02 16:12:47 UTC) #6 
Change committed as 124662

Powered by Google App Engine
This is Rietveld 408576698