Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(723)

Unified Diff: chrome/installer/util/google_chrome_distribution.cc

Issue 9565025: A little extra logging to help diagnose system-level toast issues. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/installer/util/google_chrome_distribution.cc
diff --git a/chrome/installer/util/google_chrome_distribution.cc b/chrome/installer/util/google_chrome_distribution.cc
index fa84138b96189a3e06d9cc20b9c57dca39999984..302f729079427e3354eca0a227632d98d487f13c 100644
--- a/chrome/installer/util/google_chrome_distribution.cc
+++ b/chrome/installer/util/google_chrome_distribution.cc
@@ -255,18 +255,25 @@ bool LaunchSetupAsConsoleUser(const FilePath& setup_path,
}
DWORD console_id = ::WTSGetActiveConsoleSessionId();
- if (console_id == 0xFFFFFFFF)
+ if (console_id == 0xFFFFFFFF) {
+ PLOG(ERROR) << __FUNCTION__ << " failed to get active session id";
return false;
+ }
HANDLE user_token;
- if (!::WTSQueryUserToken(console_id, &user_token))
+ if (!::WTSQueryUserToken(console_id, &user_token)) {
+ PLOG(ERROR) << __FUNCTION__ << " failed to get user token for console_id "
+ << console_id;
return false;
+ }
// Note: Handle inheritance must be true in order for the child process to be
// able to use the duplicated handle above (Google Update results).
base::LaunchOptions options;
options.as_user = user_token;
options.inherit_handles = true;
+ VLOG(1) << __FUNCTION__ << " launching " << cmd_line.GetCommandLineString();
bool launched = base::LaunchProcess(cmd_line, options, NULL);
::CloseHandle(user_token);
+ VLOG(1) << __FUNCTION__ << " result: " << launched;
return launched;
}
@@ -707,6 +714,10 @@ void GoogleChromeDistribution::LaunchUserExperiment(
const FilePath& setup_path, installer::InstallStatus status,
const Version& version, const installer::Product& product,
bool system_level) {
+ VLOG(1) << "LaunchUserExperiment status: " << status << " product: "
+ << product.distribution()->GetAppShortCutName()
+ << " system_level: " << system_level;
+
if (system_level) {
if (installer::NEW_VERSION_UPDATED == status) {
// We need to relaunch as the interactive user.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698