Add FileUtileHelper

webkit/fileapi/file_util_delete_helper.h

+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef WEBKIT_FILEAPI_FILE_UTIL_DELETE_HELPER_H_
+#define WEBKIT_FILEAPI_FILE_UTIL_DELETE_HELPER_H_
+
+#include "base/platform_file.h"
+
+namespace fileapi {
+
+class FileSystemFileUtil;
+class FileSystemOperationContext;
+class FileSystemPath;
+
+base::PlatformFileError DeletePath(FileSystemOperationContext* context,
+                                   FileSystemFileUtil* file_util,
+                                   const FileSystemPath& path,
+                                   bool recursive);

[kinuko, 2012/03/02 19:29:22]

Simple function looks good.

This changeset itself looks good now but could/should we maybe do the same thing
for CrossFileUtil?

We could add a single new file, file_util_helper.{h,cc}, and there could expose
following methods:

DeletePath
MovePath
CopyPath

or maybe like this?

// A collection of static methods that are usually called by
FileSystemFileUtilProxy and run on the FILE thread.
class FileUtilHelper {
  static PlatformFileError Delete(...);
  static PlatformFileError Move(...);
  static PlatformFileError Copy(...);
};

[tzik, 2012/03/02 21:25:47]

Done with wrapping function and to rename file_util_{delete_,}helper.
Same thing for CrossFileUtil sounds good. Yet, may I do it in another CL?

+
+base::PlatformFileError DeleteDirectoryRecursive(
+    FileSystemOperationContext* context,
+    FileSystemFileUtil* file_util,
+    const FileSystemPath& path);
+
+}  // namespace fileapi
+
+#endif  // WEBKIT_FILEAPI_FILE_UTIL_DELETE_HELPER_H_