Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(837)

Issue 9564029: [Chromoting] Log extension name and version number on startup. (Closed)

Created:
8 years, 9 months ago by garykac
Modified:
8 years, 9 months ago
Reviewers:
Jamie
CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, simonmorris+watch_chromium.org, hclam+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, alexeypa+watch_chromium.org, sergeyu+watch_chromium.org
Visibility:
Public.

Description

[Chromoting] Log extension name and version number on startup. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=124666

Patch Set 1 #

Total comments: 4

Patch Set 2 : remove locale #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -0 lines) Patch
M remoting/webapp/remoting.js View 1 2 chunks +18 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
garykac
8 years, 9 months ago (2012-03-01 22:10:32 UTC) #1
Jamie
lgtm with a couple of suggestions. http://codereview.chromium.org/9564029/diff/1/remoting/webapp/remoting.js File remoting/webapp/remoting.js (right): http://codereview.chromium.org/9564029/diff/1/remoting/webapp/remoting.js#newcode77 remoting/webapp/remoting.js:77: remoting.logExtensionInfoAsync_(); I think ...
8 years, 9 months ago (2012-03-01 22:35:41 UTC) #2
garykac
http://codereview.chromium.org/9564029/diff/1/remoting/webapp/remoting.js File remoting/webapp/remoting.js (right): http://codereview.chromium.org/9564029/diff/1/remoting/webapp/remoting.js#newcode77 remoting/webapp/remoting.js:77: remoting.logExtensionInfoAsync_(); On 2012/03/01 22:35:41, Jamie wrote: > I think ...
8 years, 9 months ago (2012-03-02 00:40:52 UTC) #3
Jamie
lgtm
8 years, 9 months ago (2012-03-02 00:51:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/garykac@chromium.org/9564029/5001
8 years, 9 months ago (2012-03-02 13:29:47 UTC) #5
commit-bot: I haz the power
8 years, 9 months ago (2012-03-02 16:51:34 UTC) #6
Change committed as 124666

Powered by Google App Engine
This is Rietveld 408576698