Issue 9564024: Re-land http://codereview.chromium.org/9403039/, r124106

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9564024: Re-land http://codereview.chromium.org/9403039/, r124106 (Closed)

Created:
8 years, 9 months ago by dmichael (off chromium)

Modified:
8 years, 9 months ago

Reviewers:

CC:
chromium-reviews, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Re-land http://codereview.chromium.org/9403039/, r124106 Original description: """ PPAPI: Really force-free NPObjects on Instance destruction. (There still seems to be a memory leak with this patch; I may have to check our NPObject reference counting next.) BUG=114023 TEST= """ BUG=114023 TEST= TBR=dmichael@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=127273

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+307 lines, -53 lines)			Patch
M	chrome/test/ui/ppapi_uitest.cc	View	1 2	2 chunks	+28 lines, -4 lines	0 comments	Download
M	ppapi/tests/test_case.h	View	1	3 chunks	+11 lines, -1 line	0 comments	Download
M	ppapi/tests/test_case.cc	View		3 chunks	+23 lines, -18 lines	0 comments	Download
M	ppapi/tests/test_case.html	View	1 2	5 chunks	+52 lines, -1 line	0 comments	Download
M	ppapi/tests/test_instance_deprecated.h	View		1 chunk	+7 lines, -0 lines	0 comments	Download
M	ppapi/tests/test_instance_deprecated.cc	View		5 chunks	+99 lines, -1 line	0 comments	Download
M	ppapi/tests/testing_instance.h	View	1 2	2 chunks	+9 lines, -0 lines	0 comments	Download
M	ppapi/tests/testing_instance.cc	View	1 2	6 chunks	+23 lines, -13 lines	0 comments	Download
M	webkit/plugins/ppapi/host_var_tracker.h	View		2 chunks	+7 lines, -1 line	0 comments	Download
M	webkit/plugins/ppapi/host_var_tracker.cc	View		3 chunks	+25 lines, -4 lines	0 comments	Download
M	webkit/plugins/ppapi/message_channel.cc	View	1	1 chunk	+2 lines, -1 line	0 comments	Download
M	webkit/plugins/ppapi/npobject_var.h	View		2 chunks	+3 lines, -1 line	0 comments	Download
M	webkit/plugins/ppapi/ppapi_plugin_instance.cc	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download
M	webkit/plugins/ppapi/ppapi_webplugin_impl.h	View		2 chunks	+2 lines, -0 lines	0 comments	Download
M	webkit/plugins/ppapi/ppapi_webplugin_impl.cc	View		4 chunks	+11 lines, -8 lines	0 comments	Download

Total messages: 3 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dmichael@chromium.org/9564024/16003

8 years, 9 months ago (2012-03-16 20:42:59 UTC) #2

Change committed as 127273