Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 9564022: Exclude NewTabPageSyncHandler for Android (Closed)

Created:
8 years, 9 months ago by Yaron
Modified:
8 years, 9 months ago
CC:
chromium-reviews, dbeam+watch-ntp_chromium.org, estade+watch_chromium.org, Jesse Greenwald
Visibility:
Public.

Description

Exclude NewTabPageSyncHandler for Android The NTP is completely different on Android and doesn't display user name or offer other sync functionality. BUG=113487 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=124696

Patch Set 1 #

Total comments: 2

Patch Set 2 : if-def include #

Total comments: 1

Patch Set 3 : fix comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M chrome/browser/ui/webui/ntp/new_tab_ui.cc View 1 2 3 chunks +7 lines, -1 line 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Yaron
Here's another reference to "sync on NTP" code. I don't think it showed up as ...
8 years, 9 months ago (2012-03-01 20:59:47 UTC) #1
Jesse Greenwald
http://codereview.chromium.org/9564022/diff/1/chrome/browser/ui/webui/ntp/new_tab_ui.cc File chrome/browser/ui/webui/ntp/new_tab_ui.cc (right): http://codereview.chromium.org/9564022/diff/1/chrome/browser/ui/webui/ntp/new_tab_ui.cc#newcode36 chrome/browser/ui/webui/ntp/new_tab_ui.cc:36: #include "chrome/browser/ui/webui/ntp/new_tab_page_sync_handler.h" #ifdef out this include?
8 years, 9 months ago (2012-03-01 21:10:15 UTC) #2
Yaron
http://codereview.chromium.org/9564022/diff/1/chrome/browser/ui/webui/ntp/new_tab_ui.cc File chrome/browser/ui/webui/ntp/new_tab_ui.cc (right): http://codereview.chromium.org/9564022/diff/1/chrome/browser/ui/webui/ntp/new_tab_ui.cc#newcode36 chrome/browser/ui/webui/ntp/new_tab_ui.cc:36: #include "chrome/browser/ui/webui/ntp/new_tab_page_sync_handler.h" On 2012/03/01 21:10:16, jgreenwald1 wrote: > #ifdef ...
8 years, 9 months ago (2012-03-01 21:16:48 UTC) #3
Evan Stade
lgtm http://codereview.chromium.org/9564022/diff/4/chrome/browser/ui/webui/ntp/new_tab_ui.cc File chrome/browser/ui/webui/ntp/new_tab_ui.cc (right): http://codereview.chromium.org/9564022/diff/4/chrome/browser/ui/webui/ntp/new_tab_ui.cc#newcode121 chrome/browser/ui/webui/ntp/new_tab_ui.cc:121: // Android does't have a sync promo/username on ...
8 years, 9 months ago (2012-03-01 22:04:07 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yfriedman@chromium.org/9564022/5
8 years, 9 months ago (2012-03-01 22:38:11 UTC) #5
commit-bot: I haz the power
Try job failure for 9564022-5 (retry) on win_rel for steps "unit_tests, browser_tests, ui_tests". It's a ...
8 years, 9 months ago (2012-03-02 02:39:54 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yfriedman@chromium.org/9564022/5
8 years, 9 months ago (2012-03-02 03:08:30 UTC) #7
commit-bot: I haz the power
Try job failure for 9564022-5 (retry) on linux_rel for step "browser_tests". It's a second try, ...
8 years, 9 months ago (2012-03-02 04:15:12 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yfriedman@chromium.org/9564022/5
8 years, 9 months ago (2012-03-02 17:19:27 UTC) #9
commit-bot: I haz the power
8 years, 9 months ago (2012-03-02 18:54:35 UTC) #10 
Change committed as 124696

Powered by Google App Engine
This is Rietveld 408576698