Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Issue 9564008: Aura: PostSubBuffer implementation for --ui-use-gpu-process (Closed)

Created:
8 years, 9 months ago by jonathan.backer
Modified:
8 years, 9 months ago
Reviewers:
apatrick_chromium
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, apatrick_chromium, pkotwicz
Visibility:
Public.

Description

Aura: PostSubBuffer implementation for --ui-use-gpu-process This refactors a bit of code from EGLImageTransportSurface for TextureImageTransportSurface. BUG=99527 TEST=run an Aura build of chrome (use_aura=1 chromeos=1) with all the flags! (--force-compositing-mode --ui-enable-partial-swap --enable-partial-swap --ui-use-gpu-process); go to google.com; see cursor blink; resize the window Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=124491

Patch Set 1 #

Patch Set 2 : "" #

Total comments: 1

Patch Set 3 : nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+110 lines, -46 lines) Patch
M content/common/gpu/image_transport_surface.h View 1 3 chunks +11 lines, -1 line 0 comments Download
M content/common/gpu/image_transport_surface.cc View 1 chunk +36 lines, -0 lines 0 comments Download
M content/common/gpu/image_transport_surface_linux.cc View 1 2 3 chunks +2 lines, -40 lines 0 comments Download
M content/common/gpu/texture_image_transport_surface.h View 1 chunk +2 lines, -0 lines 0 comments Download
M content/common/gpu/texture_image_transport_surface.cc View 1 2 3 chunks +59 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
jonathan.backer
Thanks for the code pkotwicz@.
8 years, 9 months ago (2012-03-01 14:34:01 UTC) #1
apatrick_chromium
lgtm https://chromiumcodereview.appspot.com/9564008/diff/3004/content/common/gpu/texture_image_transport_surface.cc File content/common/gpu/texture_image_transport_surface.cc (right): https://chromiumcodereview.appspot.com/9564008/diff/3004/content/common/gpu/texture_image_transport_surface.cc#newcode220 content/common/gpu/texture_image_transport_surface.cc:220: const gfx::Rect new_damage_rect = gfx::Rect(x, y, width, height); ...
8 years, 9 months ago (2012-03-01 19:35:54 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/backer@chromium.org/9564008/4004
8 years, 9 months ago (2012-03-01 19:56:52 UTC) #3
commit-bot: I haz the power
8 years, 9 months ago (2012-03-01 21:48:43 UTC) #4
Change committed as 124491

Powered by Google App Engine
This is Rietveld 408576698