Issue 9564004: Enable the option item that uses the Spelling service on Chrome OS

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9564004: Enable the option item that uses the Spelling service on Chrome OS (Closed)

Created:
8 years, 9 months ago by Hironori Bono

Modified:
8 years, 9 months ago

Reviewers:
csilv

CC:
chromium-reviews, arv (Not doing code reviews)

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Enable the option item that uses the Spelling service on Chrome OS This change enables a check item "Use a web service to help resolve spelling errors" added by r122728 <http://crrev.com/122728>; also on Chrome OS. It also moves the position of this item above the "Automatically send usage statistics..." item as suggested in a privacy review. BUG=103840 TEST=manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=124642

Patch Set 1 #

Patch Set 2 : #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -20 lines)			Patch
	M	chrome/browser/resources/options/advanced_options.html	View	1	2 chunks	+10 lines, -10 lines	0 comments	Download
	M	chrome/browser/resources/options2/browser_options.html	View	1	2 chunks	+10 lines, -10 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Hironori Bono

Greetings Chris, I have verified this Spelling feature works well on Chromium OS and like ...

8 years, 9 months ago (2012-03-01 11:01:04 UTC) #1

csilv

lgtm lgtm. please be aware that as of today, options2/advanced_options has been merged into options2/browser_options.

8 years, 9 months ago (2012-03-01 20:37:09 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hbono@chromium.org/9564004/1003

8 years, 9 months ago (2012-03-02 04:46:41 UTC) #3

Change committed as 124642

Expand Messages | Collapse Messages