Chromium Code Reviews| OLD | NEW |
|---|---|
| 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. | 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. |
| 2 // Use of this source code is governed by a BSD-style license that can be | 2 // Use of this source code is governed by a BSD-style license that can be |
| 3 // found in the LICENSE file. | 3 // found in the LICENSE file. |
| 4 | 4 |
| 5 cr.define('options', function() { | 5 cr.define('options', function() { |
| 6 var OptionsPage = options.OptionsPage; | 6 var OptionsPage = options.OptionsPage; |
| 7 var ArrayDataModel = cr.ui.ArrayDataModel; | 7 var ArrayDataModel = cr.ui.ArrayDataModel; |
| 8 var RepeatingButton = cr.ui.RepeatingButton; | 8 var RepeatingButton = cr.ui.RepeatingButton; |
| 9 | 9 |
| 10 // | 10 // |
| (...skipping 62 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 73 // Internet connection section (ChromeOS only). | 73 // Internet connection section (ChromeOS only). |
| 74 if (cr.isChromeOS) { | 74 if (cr.isChromeOS) { |
| 75 $('internet-options-button').onclick = function(event) { | 75 $('internet-options-button').onclick = function(event) { |
| 76 OptionsPage.navigateToPage('internet'); | 76 OptionsPage.navigateToPage('internet'); |
| 77 chrome.send('coreOptionsUserMetricsAction', | 77 chrome.send('coreOptionsUserMetricsAction', |
| 78 ['Options_InternetOptions']); | 78 ['Options_InternetOptions']); |
| 79 }; | 79 }; |
| 80 } | 80 } |
| 81 | 81 |
| 82 // On Startup section. | 82 // On Startup section. |
| 83 $('startup-set-pages').onclick = function() { | 83 var startupSetPagesLink = $('startup-set-pages'); |
| 84 OptionsPage.navigateToPage('startup'); | 84 const showPagesValue = Number($('startup-show-pages').value); |
| 85 | |
| 86 Preferences.getInstance().addEventListener( | |
| 87 'session.restore_on_startup', | |
| 88 function(event) { | |
| 89 startupSetPagesLink.disabled = | |
|
Evan Stade
2012/03/02 03:38:35
this indent can't be right.
Tyler Breisacher (Chromium)
2012/03/02 04:10:46
Is this better?
| |
| 90 event.value['disabled'] && event.value['value'] != showPagesValue; | |
| 91 }); | |
| 92 | |
| 93 startupSetPagesLink.onclick = function() { | |
| 94 if (!startupSetPagesLink.disabled) | |
|
Evan Stade
2012/03/02 03:38:35
is this required? disabled buttons can't be clicke
Tyler Breisacher (Chromium)
2012/03/02 04:10:46
I forgot it's actually a button, not a link. Done.
| |
| 95 OptionsPage.navigateToPage('startup'); | |
| 85 }; | 96 }; |
| 86 | 97 |
| 87 this.sessionRestoreEnabled_ = templateData.enable_restore_session_state; | 98 this.sessionRestoreEnabled_ = templateData.enable_restore_session_state; |
| 88 if (this.sessionRestoreEnabled_) { | 99 if (this.sessionRestoreEnabled_) { |
| 89 $('old-startup-last-text').hidden = true; | 100 $('old-startup-last-text').hidden = true; |
| 90 $('new-startup-last-text').hidden = false; | 101 $('new-startup-last-text').hidden = false; |
| 91 } | 102 } |
| 92 | 103 |
| 93 // Appearance section. | 104 // Appearance section. |
| 94 $('home-page-select').addEventListener( | 105 $('home-page-select').addEventListener( |
| (...skipping 1124 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 1219 BrowserOptions.getLoggedInUsername = function() { | 1230 BrowserOptions.getLoggedInUsername = function() { |
| 1220 return BrowserOptions.getInstance().username_; | 1231 return BrowserOptions.getInstance().username_; |
| 1221 }; | 1232 }; |
| 1222 } | 1233 } |
| 1223 | 1234 |
| 1224 // Export | 1235 // Export |
| 1225 return { | 1236 return { |
| 1226 BrowserOptions: BrowserOptions | 1237 BrowserOptions: BrowserOptions |
| 1227 }; | 1238 }; |
| 1228 }); | 1239 }); |
| OLD | NEW |