Implement Linux media notifier.

content/browser/browser_main_loop.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/browser_main_loop.h"
 
+#include <string>

[jam, 2012/03/06 21:21:38]

nit: no need. i understand you're adding it for IWYU, but this is such a base
include file

[Lei Zhang, 2012/03/06 21:36:50]

Done.

+
 #include "base/bind.h"
 #include "base/command_line.h"
 #include "base/debug/trace_event.h"
 #include "base/logging.h"
 #include "base/message_loop.h"
 #include "base/metrics/field_trial.h"
 #include "base/metrics/histogram.h"
 #include "base/string_number_conversions.h"
 #include "base/threading/thread_restrictions.h"
 #include "content/browser/browser_thread_impl.h"
@@ skipping 30 matching lines @@
 #include <windows.h>
 #include <commctrl.h>
 #include <ole2.h>
 #include <shellapi.h>
 
 #include "content/browser/system_message_window_win.h"
 #include "ui/base/l10n/l10n_util_win.h"
 #include "net/base/winsock_init.h"
 #endif
 
+#if defined(OS_LINUX)
+#include "content/browser/media_device_notifications_linux.h"
+#endif
+
 #if defined(OS_LINUX) || defined(OS_OPENBSD)
 #include <glib-object.h>
 #endif
 
 #if defined(OS_CHROMEOS)
 #include <dbus/dbus-glib.h>
 #endif
 
 #if defined(TOOLKIT_USES_GTK)
 #include "ui/gfx/gtk_util.h"
@@ skipping 130 matching lines @@
 
 void ImmediateShutdownAndExitProcess() {
   BrowserShutdownImpl::ImmediateShutdownAndExitProcess();
 }
 
 // static
 AudioManager* BrowserMainLoop::GetAudioManager() {
   return g_current_browser_main_loop->audio_manager_.get();
 }
 
-// BrowserMainLoop construction / destructione =============================
+// BrowserMainLoop construction / destruction =============================
 
 BrowserMainLoop::BrowserMainLoop(const content::MainFunctionParams& parameters)
     : parameters_(parameters),
       parsed_command_line_(parameters.command_line),
       result_code_(content::RESULT_CODE_NORMAL_EXIT) {
   DCHECK(!g_current_browser_main_loop);
   g_current_browser_main_loop = this;
 #if defined(OS_WIN)
   OleInitialize(NULL);
 #endif
@@ skipping 362 matching lines @@
 
   // Register the main thread by instantiating it, but don't call any methods.
   main_thread_.reset(new BrowserThreadImpl(BrowserThread::UI,
                                            MessageLoop::current()));
 }
 
 
 void BrowserMainLoop::BrowserThreadsStarted() {
   // RDH needs the IO thread to be created.
   resource_dispatcher_host_.reset(new ResourceDispatcherHost());
+
+#if defined(OS_LINUX)
+  // MediaDeviceNotificationsLinux needs the File Thread.
+  const FilePath kDefaultMtabPath("/etc/mtab");
+  media_device_notifications_linux_ =
+      new MediaDeviceNotificationsLinux(kDefaultMtabPath);
+  BrowserThread::PostTask(
+      BrowserThread::FILE, FROM_HERE,

[jam, 2012/03/06 21:21:38]

nit: it's nicer if this class can do its thread initialization itself, to keep
BrowserMainLoop small and not have to worry about implementation details. this
class can just call an Init() method that internally does this

[Lei Zhang, 2012/03/06 21:36:50]

Done.

[jam, 2012/03/06 22:22:11]

you have do it in in a separate method, i.e. after the calling code has a
reference. otherwise if the task runs on the file thread before the constructor
returns, the object will be deleted.

if you try this in debug builds, it'll crash right away because the PostTask
will do release/addref first

[Lei Zhang, 2012/03/06 23:23:42]

Oh thanks for reminding me about that. Fixed.

+      base::Bind(&MediaDeviceNotificationsLinux::InitOnFileThread,
+                 media_device_notifications_linux_.get()));
+#endif
 }
 
 void BrowserMainLoop::InitializeToolkit() {
   // TODO(evan): this function is rather subtle, due to the variety
   // of intersecting ifdefs we have.  To keep it easy to follow, there
   // are no #else branches on any #ifs.
   // TODO(stevenjb): Move platform specific code into platform specific Parts
   // (Need to add InitializeToolkit stage to BrowserParts).
 #if defined(OS_LINUX) || defined(OS_OPENBSD)
   // Glib type system initialization. Needed at least for gconf,
@@ skipping 38 matching lines @@
     MessageLoopForUI::current()->PostTask(FROM_HERE, *parameters_.ui_task);
 
 #if defined(OS_MACOSX)
   MessageLoopForUI::current()->Run();
 #else
   MessageLoopForUI::current()->RunWithDispatcher(NULL);
 #endif
 }
 
 }  // namespace content