Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1086)

Side by Side Diff: chrome/browser/ui/panels/panel.h

Issue 9560002: Cleanup to keep panel from manipulating its panel strip assignment directly. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: addressed final nits Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/browser/ui/panels/overflow_panel_strip.cc ('k') | chrome/browser/ui/panels/panel.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_PANELS_PANEL_H_ 5 #ifndef CHROME_BROWSER_UI_PANELS_PANEL_H_
6 #define CHROME_BROWSER_UI_PANELS_PANEL_H_ 6 #define CHROME_BROWSER_UI_PANELS_PANEL_H_
7 #pragma once 7 #pragma once
8 8
9 #include "chrome/browser/ui/browser_window.h" 9 #include "chrome/browser/ui/browser_window.h"
10 10
(...skipping 204 matching lines...) Expand 10 before | Expand all | Expand 10 after
215 215
216 // Asynchronous completion of panel close request. 216 // Asynchronous completion of panel close request.
217 void OnNativePanelClosed(); 217 void OnNativePanelClosed();
218 218
219 NativePanel* native_panel() { return native_panel_; } 219 NativePanel* native_panel() { return native_panel_; }
220 Browser* browser() const { return browser_; } 220 Browser* browser() const { return browser_; }
221 221
222 // May be NULL if panel is newly created and has not been positioned yet. 222 // May be NULL if panel is newly created and has not been positioned yet.
223 PanelStrip* panel_strip() const { return panel_strip_; } 223 PanelStrip* panel_strip() const { return panel_strip_; }
224 224
225 // Moves the panel to the |new_strip|, removing the panel from its 225 // Sets the current panel strip that contains this panel.
226 // current strip. 226 void set_panel_strip(PanelStrip* new_strip) { panel_strip_ = new_strip; }
227 void MoveToStrip(PanelStrip* new_strip);
228 227
229 ExpansionState expansion_state() const { return expansion_state_; } 228 ExpansionState expansion_state() const { return expansion_state_; }
230 ExpansionState old_expansion_state() const { return old_expansion_state_; } 229 ExpansionState old_expansion_state() const { return old_expansion_state_; }
231 const gfx::Size& min_size() const { return min_size_; } 230 const gfx::Size& min_size() const { return min_size_; }
232 const gfx::Size& max_size() const { return max_size_; } 231 const gfx::Size& max_size() const { return max_size_; }
233 bool auto_resizable() const { return auto_resizable_; } 232 bool auto_resizable() const { return auto_resizable_; }
234 233
235 bool draggable() const; 234 bool draggable() const;
236 235
237 // The restored size is the size of the panel when it is expanded. 236 // The restored size is the size of the panel when it is expanded.
(...skipping 85 matching lines...) Expand 10 before | Expand all | Expand 10 after
323 322
324 // Indicates whether the panel app icon is visible in the taskbar. 323 // Indicates whether the panel app icon is visible in the taskbar.
325 bool app_icon_visible_; 324 bool app_icon_visible_;
326 325
327 content::NotificationRegistrar registrar_; 326 content::NotificationRegistrar registrar_;
328 327
329 DISALLOW_COPY_AND_ASSIGN(Panel); 328 DISALLOW_COPY_AND_ASSIGN(Panel);
330 }; 329 };
331 330
332 #endif // CHROME_BROWSER_UI_PANELS_PANEL_H_ 331 #endif // CHROME_BROWSER_UI_PANELS_PANEL_H_
OLDNEW
« no previous file with comments | « chrome/browser/ui/panels/overflow_panel_strip.cc ('k') | chrome/browser/ui/panels/panel.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698