Record taskbar launch mode in UMA histogram

Record taskbar launch mode in UMA histogram

The launch.mode histogram has been updated to track taskbar launches. As there was already a bucket for start menu which was never used, this is now used for the taskbar. Previously task bar launches have been recorded in the quick launch bucket.

BUG=103977
TEST=Tested with the aid of logging on Windows 7.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=124636

[benwells, 2012-03-01 04:33:25]

As mentioned in the summary taskbar launches are now put in the quick launch
bucket. I don't know how good the querying of UMA stats is, maybe you can
already see taskbar launches by looking for quick launch and windows7.

If not, this is a change to split it out. Let me know if the start menu is
reserved for future use and I'll use another bucket.

[cpu_(ooo_6.6-7.5), 2012-03-02 00:45:14]

http://codereview.chromium.org/9559020/diff/1/chrome/browser/ui/browser_init.cc
File chrome/browser/ui/browser_init.cc (right):

http://codereview.chromium.org/9559020/diff/1/chrome/browser/ui/browser_init....
chrome/browser/ui/browser_init.cc:496: LM_SHORTCUT_TASKBAR,        // Launched
from task bar.
I believe is called "taskbar" but I could be wrong.

http://codereview.chromium.org/9559020/diff/1/chrome/browser/ui/browser_init....
chrome/browser/ui/browser_init.cc:513: if (base::win::GetVersion() >=
base::win::VERSION_WIN7)
use { in line 512.

If statements without {} are for one line statements.

[cpu_(ooo_6.6-7.5), 2012-03-02 00:46:24]

you can have my lgtm if you do the above.

[benwells, 2012-03-02 00:58:53]

+sky as owner of /chrome/browser/ui

http://codereview.chromium.org/9559020/diff/1/chrome/browser/ui/browser_init.cc
File chrome/browser/ui/browser_init.cc (right):

http://codereview.chromium.org/9559020/diff/1/chrome/browser/ui/browser_init....
chrome/browser/ui/browser_init.cc:496: LM_SHORTCUT_TASKBAR,        // Launched
from task bar.
On 2012/03/02 00:45:14, cpu wrote:
> I believe is called "taskbar" but I could be wrong.

Done.

http://codereview.chromium.org/9559020/diff/1/chrome/browser/ui/browser_init....
chrome/browser/ui/browser_init.cc:513: if (base::win::GetVersion() >=
base::win::VERSION_WIN7)
On 2012/03/02 00:45:14, cpu wrote:
> use { in line 512.
> 
> If statements without {} are for one line statements.

Done.

[sky, 2012-03-02 01:14:09]

LGTM

[commit-bot: I haz the power, 2012-03-02 01:16:16]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/benwells@chromium.org/9559020/3002

[commit-bot: I haz the power, 2012-03-02 14:57:52]

Change committed as 124636