Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Issue 9559016: Fix pyauto breakage. (Closed)

Created:
8 years, 9 months ago by Tyler Breisacher (Chromium)
Modified:
8 years, 9 months ago
Reviewers:
Nirnimesh
CC:
chromium-reviews, dennis_jeffrey, John Grabowski, anantha, dyu1, Nirnimesh
Visibility:
Public.

Description

Fix pyauto breakage. Some tests assume that about:blank will load at startup when --homepage=about:blank is passed. Now chrome://newtab/ loads instead, so we need to take that into account BUG=none TEST=shortcuts.ShortcutsTest.testViewSourceShortcut, multiprofile.MultiprofileTest.testBasic, instant.InstantTest Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=124406

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -6 lines) Patch
M chrome/test/functional/instant.py View 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/test/functional/multiprofile.py View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/functional/shortcuts.py View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Tyler Breisacher (Chromium)
8 years, 9 months ago (2012-03-01 02:46:41 UTC) #1
Nirnimesh
lgtm
8 years, 9 months ago (2012-03-01 09:55:41 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tbreisacher@chromium.org/9559016/1
8 years, 9 months ago (2012-03-01 09:55:50 UTC) #3
commit-bot: I haz the power
8 years, 9 months ago (2012-03-01 12:27:13 UTC) #4
Change committed as 124406

Powered by Google App Engine
This is Rietveld 408576698