Exclude browser/importer from Android build.

Exclude browser/importer from Android build.

The code in browser/importer is currently causing linker errors when trying to build sync_unit_tests.  Chrome on Android handles importing system settings differently, so this is not needed.

BUG=113487
TEST=


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=124452

[Jesse Greenwald, 2012-03-01 01:48:05]

mirandac: Adding since you're in the owners file for importer.

yfriedman: Adding in case you wanted to take a look at this.

[Jesse Greenwald, 2012-03-01 01:54:10]

eroman: Can you take a look at the change to
'chrome/browser/net/connection_tester.cc'?

[Yaron, 2012-03-01 02:20:30]

http://codereview.chromium.org/9559014/diff/1/chrome/browser/net/connection_t...
File chrome/browser/net/connection_tester.cc (right):

http://codereview.chromium.org/9559014/diff/1/chrome/browser/net/connection_t...
chrome/browser/net/connection_tester.cc:232: return net::ERR_FAILED;
Looking above, it seems like theres' precedent for this but it seems like the
return type should be net::ERR_NOT_IMPLEMENTED

[eroman, 2012-03-01 02:21:12]

LGTM

+1 on using NOT_IMPLEMENTED

http://codereview.chromium.org/9559014/diff/1/chrome/browser/net/connection_t...
File chrome/browser/net/connection_tester.cc (right):

http://codereview.chromium.org/9559014/diff/1/chrome/browser/net/connection_t...
chrome/browser/net/connection_tester.cc:15: #include
"chrome/browser/importer/firefox_proxy_settings.h"
You should probably if-def this out too

[Miranda Callahan, 2012-03-01 14:32:48]

On 2012/03/01 02:21:12, eroman wrote:
> LGTM
> 
> +1 on using NOT_IMPLEMENTED
> 
>
http://codereview.chromium.org/9559014/diff/1/chrome/browser/net/connection_t...
> File chrome/browser/net/connection_tester.cc (right):
> 
>
http://codereview.chromium.org/9559014/diff/1/chrome/browser/net/connection_t...
> chrome/browser/net/connection_tester.cc:15: #include
> "chrome/browser/importer/firefox_proxy_settings.h"
> You should probably if-def this out too

LGTM.

[commit-bot: I haz the power, 2012-03-01 17:13:13]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jgreenwald@chromium.org/9559014/6001

[commit-bot: I haz the power, 2012-03-01 17:13:20]

Presubmit check for 9559014-6001 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit Messages **
If this change requires manual test instructions to QA team, add
TEST=[instructions].

** Presubmit ERRORS **
Missing LGTM from an OWNER for:
chrome/browser/bookmarks/bookmark_extension_api.cc

Presubmit checks took 4.9s to calculate.

[Jesse Greenwald, 2012-03-01 17:21:02]

sky: Can you review chrome/browser/bookmarks/bookmark_extension_api.cc?

Thanks

[Yaron, 2012-03-01 17:38:43]

http://codereview.chromium.org/9559014/diff/6001/chrome/browser/net/connectio...
File chrome/browser/net/connection_tester.cc (right):

http://codereview.chromium.org/9559014/diff/6001/chrome/browser/net/connectio...
chrome/browser/net/connection_tester.cc:15: #if !defined(OS_ANDROID)
NIT: platform-specific includes are supposed to come after all includes (yes we
have lots of violations downstream)

[sky, 2012-03-01 17:40:27]

Make sure you address TODO from Yaron.
LGTM otherwise.

[commit-bot: I haz the power, 2012-03-01 17:54:48]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jgreenwald@chromium.org/9559014/11001

[commit-bot: I haz the power, 2012-03-01 19:38:38]

Change committed as 124452