Add an android specific ntp resource cache.

Add an android specific ntp resource cache.

This is a minimal starting point for merging our upstream android
ntp resource changes into a somewhat clean slate.  Based on how little of the
shared resource cache code we used, it seems cleaner to start our own and
not muddle that file with a ton of ifdefs.

This is all in the hopes of getting sync_unit_tests linking upstream.

BUG=113487
TEST=


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=124767

[Evan Stade, 2012-03-01 03:32:34]

lgtm

[Dan Beam, 2012-03-01 03:45:32]

drive by comments

http://codereview.chromium.org/9558014/diff/1/chrome/browser/ui/webui/ntp/ntp...
File chrome/browser/ui/webui/ntp/ntp_resource_cache.h (right):

http://codereview.chromium.org/9558014/diff/1/chrome/browser/ui/webui/ntp/ntp...
chrome/browser/ui/webui/ntp/ntp_resource_cache.h:59:
scoped_refptr<RefCountedMemory> new_tab_html_;
you could probably combine these, as they exist in both blocks, btw.

http://codereview.chromium.org/9558014/diff/1/chrome/browser/ui/webui/ntp/ntp...
File chrome/browser/ui/webui/ntp/ntp_resource_cache_android.cc (right):

http://codereview.chromium.org/9558014/diff/1/chrome/browser/ui/webui/ntp/ntp...
chrome/browser/ui/webui/ntp/ntp_resource_cache_android.cc:7: #include
"base/command_line.h"
I don't think you need many of these headers.

http://codereview.chromium.org/9558014/diff/1/chrome/browser/ui/webui/ntp/ntp...
chrome/browser/ui/webui/ntp/ntp_resource_cache_android.cc:55: // No
notificaitons necessary in Android.
notifications

http://codereview.chromium.org/9558014/diff/1/chrome/browser/ui/webui/ntp/ntp...
chrome/browser/ui/webui/ntp/ntp_resource_cache_android.cc:85: // Load the new
tab page appropriate for this build
nit: end comment with .

[Ted C, 2012-03-01 18:35:54]

http://codereview.chromium.org/9558014/diff/1/chrome/browser/ui/webui/ntp/ntp...
File chrome/browser/ui/webui/ntp/ntp_resource_cache.h (right):

http://codereview.chromium.org/9558014/diff/1/chrome/browser/ui/webui/ntp/ntp...
chrome/browser/ui/webui/ntp/ntp_resource_cache.h:59:
scoped_refptr<RefCountedMemory> new_tab_html_;
On 2012/03/01 03:45:32, Dan Beam wrote:
> you could probably combine these, as they exist in both blocks, btw.

Done

http://codereview.chromium.org/9558014/diff/1/chrome/browser/ui/webui/ntp/ntp...
File chrome/browser/ui/webui/ntp/ntp_resource_cache_android.cc (right):

http://codereview.chromium.org/9558014/diff/1/chrome/browser/ui/webui/ntp/ntp...
chrome/browser/ui/webui/ntp/ntp_resource_cache_android.cc:7: #include
"base/command_line.h"
On 2012/03/01 03:45:32, Dan Beam wrote:
> I don't think you need many of these headers.

Ah yes...I initially had this file match closer what we had downstream but I
found many of the dependencies had not yet been upstreamed.  Forgot to clean up
the includes...done (turned out only command_line wasn't used -- almost all
others have only a single usage which makes them harder to spot).

http://codereview.chromium.org/9558014/diff/1/chrome/browser/ui/webui/ntp/ntp...
chrome/browser/ui/webui/ntp/ntp_resource_cache_android.cc:55: // No
notificaitons necessary in Android.
On 2012/03/01 03:45:32, Dan Beam wrote:
> notifications

Done.

http://codereview.chromium.org/9558014/diff/1/chrome/browser/ui/webui/ntp/ntp...
chrome/browser/ui/webui/ntp/ntp_resource_cache_android.cc:85: // Load the new
tab page appropriate for this build
On 2012/03/01 03:45:32, Dan Beam wrote:
> nit: end comment with .

Done.

[Yaron, 2012-03-01 18:55:44]

lgtm

[commit-bot: I haz the power, 2012-03-01 23:07:48]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tedchoc@chromium.org/9558014/4001

[commit-bot: I haz the power, 2012-03-01 23:07:51]

Can't apply patch for file chrome/chrome_browser.gypi.
While running patch -p1 --forward --force;
patching file chrome/chrome_browser.gypi
Hunk #1 succeeded at 4044 (offset 8 lines).
Hunk #2 FAILED at 4739.
1 out of 2 hunks FAILED -- saving rejects to file chrome/chrome_browser.gypi.rej

[commit-bot: I haz the power, 2012-03-01 23:15:28]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tedchoc@chromium.org/9558014/4002

[commit-bot: I haz the power, 2012-03-02 02:54:25]

Try job failure for 9558014-4002 (retry) on win_rel for step "ui_tests".
It's a second try, previously, step "ui_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2012-03-02 21:24:35]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tedchoc@chromium.org/9558014/4002

[commit-bot: I haz the power, 2012-03-02 23:25:19]

Change committed as 124767