Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 9558012: Cleanup: IWYU for BrowserThread. (Closed)

Created:
8 years, 9 months ago by Lei Zhang
Modified:
8 years, 9 months ago
CC:
chromium-reviews, mihaip+watch_chromium.org, dcheng, joi+watch-content_chromium.org, Aaron Boodman, darin-cc_chromium.org, rdsmith+dwatch_chromium.org
Visibility:
Public.

Description

Cleanup: IWYU for BrowserThread. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=124852

Patch Set 1 #

Total comments: 2

Patch Set 2 : remove nolint #

Patch Set 3 : fix win,mac,cros #

Patch Set 4 : fix win #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -38 lines) Patch
M chrome/browser/browsing_data_remover.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chromeos/login/login_performer.cc View 1 2 2 chunks +19 lines, -18 lines 0 comments Download
M chrome/browser/extensions/extension_process_manager.cc View 4 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/extensions/key_identifier_conversion_views.cc View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/prefs/pref_member.h View 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/profiles/refcounted_profile_keyed_service_factory.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_blocking_page.h View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/sync/glue/non_frontend_data_type_controller.h View 1 2 3 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/dock_icon.mm View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/gtk/select_file_dialog_impl_kde.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/web_applications/web_app_linux.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/web_applications/web_app_win.cc View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/browser_thread_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/browser_thread_impl.cc View 3 chunks +5 lines, -3 lines 0 comments Download
M content/browser/download/drag_download_util.cc View 2 chunks +6 lines, -3 lines 0 comments Download
M content/browser/in_process_webkit/indexed_db_quota_client.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/power_save_blocker_win.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M content/public/browser/browser_thread.h View 2 chunks +5 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
Lei Zhang
jam: content/browser rdsmith: content/browser/download erg: chrome/browser/profiles and chrome/browser/ui/gtk
8 years, 9 months ago (2012-03-01 01:23:06 UTC) #1
jam
http://codereview.chromium.org/9558012/diff/1/chrome/browser/ui/gtk/select_file_dialog_impl_kde.cc File chrome/browser/ui/gtk/select_file_dialog_impl_kde.cc (right): http://codereview.chromium.org/9558012/diff/1/chrome/browser/ui/gtk/select_file_dialog_impl_kde.cc#newcode24 chrome/browser/ui/gtk/select_file_dialog_impl_kde.cc:24: #include <gdk/gdkx.h> // NOLINT ugh, why?
8 years, 9 months ago (2012-03-01 01:25:15 UTC) #2
Lei Zhang
http://codereview.chromium.org/9558012/diff/1/chrome/browser/ui/gtk/select_file_dialog_impl_kde.cc File chrome/browser/ui/gtk/select_file_dialog_impl_kde.cc (right): http://codereview.chromium.org/9558012/diff/1/chrome/browser/ui/gtk/select_file_dialog_impl_kde.cc#newcode24 chrome/browser/ui/gtk/select_file_dialog_impl_kde.cc:24: #include <gdk/gdkx.h> // NOLINT On 2012/03/01 01:25:15, John Abd-El-Malek ...
8 years, 9 months ago (2012-03-01 01:33:19 UTC) #3
jam
On 2012/03/01 01:33:19, Lei Zhang wrote: > http://codereview.chromium.org/9558012/diff/1/chrome/browser/ui/gtk/select_file_dialog_impl_kde.cc > File chrome/browser/ui/gtk/select_file_dialog_impl_kde.cc (right): > > http://codereview.chromium.org/9558012/diff/1/chrome/browser/ui/gtk/select_file_dialog_impl_kde.cc#newcode24 ...
8 years, 9 months ago (2012-03-01 01:35:43 UTC) #4
Lei Zhang
+ additional owners
8 years, 9 months ago (2012-03-01 08:21:48 UTC) #5
Randy Smith (Not in Mondays)
content/browser/download LGTM.
8 years, 9 months ago (2012-03-01 16:24:54 UTC) #6
Elliot Glaysher
lgtm
8 years, 9 months ago (2012-03-01 20:10:27 UTC) #7
Lei Zhang
akalin: OWNERS review for chrome/browser/sync/glue/non_frontend_data_type_controller.h avi: OWNERS review for chrome/browser/ui/cocoa/dock_icon.mm. Please also look at new ...
8 years, 9 months ago (2012-03-02 07:32:31 UTC) #8
akalin
sync lgtm
8 years, 9 months ago (2012-03-02 23:03:31 UTC) #9
Avi (use Gerrit)
On 2012/03/02 07:32:31, Lei Zhang wrote: > avi: OWNERS review for chrome/browser/ui/cocoa/dock_icon.mm. Please also look ...
8 years, 9 months ago (2012-03-03 02:45:46 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/9558012/12004
8 years, 9 months ago (2012-03-03 05:51:09 UTC) #11
commit-bot: I haz the power
8 years, 9 months ago (2012-03-03 09:00:10 UTC) #12 
Change committed as 124852

Powered by Google App Engine
This is Rietveld 408576698