Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Issue 9558011: Remove memcheck suppressions for 109491 and 115808 (Closed)

Created:
8 years, 9 months ago by bashi
Modified:
8 years, 9 months ago
CC:
chromium-reviews, glider+watch_chromium.org, pam+watch_chromium.org, timurrrr+watch_chromium.org, bruening+watch_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Remove memcheck suppressions for 109491 and 115808 WebKit r109175 and r109220 fixed uninitialized variables access. BUG=109491, 115808 TEST=ran memcheck Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=124389

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -46 lines) Patch
M tools/valgrind/memcheck/suppressions.txt View 2 chunks +0 lines, -46 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
bashi
Hi thakis, I assume you are the memory sheriff now. Could you take a look?
8 years, 9 months ago (2012-03-01 01:12:43 UTC) #1
Nico
Thanks for your patch! Can this wait a bit? The memory waterfall is currently very ...
8 years, 9 months ago (2012-03-01 01:21:39 UTC) #2
bashi
On 2012/03/01 01:21:39, Nico wrote: > Thanks for your patch! > > Can this wait ...
8 years, 9 months ago (2012-03-01 01:25:17 UTC) #3
Nico
lgtm
8 years, 9 months ago (2012-03-01 03:08:58 UTC) #4
bashi
On 2012/03/01 03:08:58, Nico wrote: > lgtm Thank you!
8 years, 9 months ago (2012-03-01 04:03:04 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bashi@chromium.org/9558011/1
8 years, 9 months ago (2012-03-01 04:03:07 UTC) #6
commit-bot: I haz the power
Try job failure for 9558011-1 (retry) on win_rel for step "compile" (clobber build). It's a ...
8 years, 9 months ago (2012-03-01 05:06:48 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bashi@chromium.org/9558011/1
8 years, 9 months ago (2012-03-01 05:08:14 UTC) #8
commit-bot: I haz the power
8 years, 9 months ago (2012-03-01 09:41:55 UTC) #9
Change committed as 124389

Powered by Google App Engine
This is Rietveld 408576698