Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Issue 9558009: Add HandleInputEventAck message to allow out-of-process plugins to respond to user gestures. (Closed)

Created:
8 years, 9 months ago by bbudge
Modified:
8 years, 9 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Add HandleInputEventAck message to allow out-of-process plugins to respond to user gestures. Modifies PluginInstance to track pending user gestures by timestamp. Modifies ppapi/tests/test_fullscreen to not test that SetFullscreen and BindGraphics fail while fullscreen changes are pending. Because of how PluginInstance reports view changed events, these will likely fail due to race conditions. BUG=73070 TEST=ui_tests, --gtest_filter=*PPAPITest.Fullscreen Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=125768

Patch Set 1 : #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+111 lines, -88 lines) Patch
M chrome/test/ui/ppapi_uitest.cc View 1 2 3 4 5 1 chunk +2 lines, -13 lines 0 comments Download
M ppapi/proxy/ppapi_messages.h View 1 2 3 4 5 2 chunks +5 lines, -0 lines 0 comments Download
M ppapi/proxy/ppb_instance_proxy.h View 1 2 3 4 5 4 chunks +6 lines, -1 line 0 comments Download
M ppapi/proxy/ppb_instance_proxy.cc View 1 2 3 4 5 4 chunks +16 lines, -0 lines 0 comments Download
M ppapi/proxy/ppp_input_event_proxy.h View 1 2 3 4 5 2 chunks +3 lines, -0 lines 0 comments Download
M ppapi/proxy/ppp_input_event_proxy.cc View 1 2 3 4 5 2 chunks +14 lines, -0 lines 0 comments Download
M ppapi/tests/test_fullscreen.h View 1 2 3 4 5 1 chunk +0 lines, -1 line 0 comments Download
M ppapi/tests/test_fullscreen.cc View 1 2 3 4 5 7 chunks +11 lines, -59 lines 0 comments Download
M ppapi/thunk/ppb_instance_api.h View 1 2 3 4 5 2 chunks +5 lines, -2 lines 0 comments Download
M webkit/plugins/ppapi/ppapi_plugin_instance.h View 1 2 3 4 5 5 chunks +14 lines, -4 lines 0 comments Download
M webkit/plugins/ppapi/ppapi_plugin_instance.cc View 1 2 3 4 5 7 chunks +35 lines, -8 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
bbudge
Elevated this because of GTalk Pepper plugin. Looking for direction on overall shape of the ...
8 years, 9 months ago (2012-03-02 01:27:18 UTC) #1
brettw
Is it possible to keep the timestamp of only the most recent input event? When ...
8 years, 9 months ago (2012-03-02 05:48:48 UTC) #2
bbudge
Changed to only keep a single pending user gesture. One weakness of this scheme is ...
8 years, 9 months ago (2012-03-02 21:49:17 UTC) #3
brettw
Yeah, I was envisioning some kind of check that would test the timeout before any ...
8 years, 9 months ago (2012-03-02 23:29:46 UTC) #4
bbudge
I modified the CL to measure elapsed time and left in the ACK message so ...
8 years, 9 months ago (2012-03-03 02:18:08 UTC) #5
bbudge
8 years, 9 months ago (2012-03-07 20:33:56 UTC) #6
bbudge
Modified the tests to accept a variable number of DidChangeView notifications. Depending on an exact ...
8 years, 9 months ago (2012-03-07 21:51:31 UTC) #7
bbudge
Looks like PPAPITest.Fullscreen and OutOfProcessPPAPITest.Fullscreen are passing on all platforms.
8 years, 9 months ago (2012-03-08 01:22:28 UTC) #8
brettw
lgtm
8 years, 9 months ago (2012-03-08 22:17:33 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bbudge@chromium.org/9558009/26018
8 years, 9 months ago (2012-03-08 22:28:16 UTC) #10
commit-bot: I haz the power
8 years, 9 months ago (2012-03-09 02:08:35 UTC) #11
Change committed as 125768

Powered by Google App Engine
This is Rietveld 408576698