Working around http://code.google.com/p/gyp/issues/detail?id=13

Working around http://code.google.com/p/gyp/issues/detail?id=13

Visual Studio doesn't guarantee the 'copies' stanza is executed after the grit target, which can lead to a failure if it tries to copy the file before it's been generated. This puts the grit action in its own target, and making the copies stanza its own target that depends on the grit target.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=124345

[bradn, 2012-02-29 22:16:43]

https://chromiumcodereview.appspot.com/9558003/diff/1/content/content_resourc...
File content/content_resources.gyp (right):

https://chromiumcodereview.appspot.com/9558003/diff/1/content/content_resourc...
content/content_resources.gyp:19: 'inputs': [
You shouldn't have the 'inputs' and 'outputs' sections, the copies section is
adequate. Gyp's super cool parser is likely ignore these.

[Myles C. Maxfield, 2012-02-29 22:21:51]

https://chromiumcodereview.appspot.com/9558003/diff/1/content/content_resourc...
File content/content_resources.gyp (right):

https://chromiumcodereview.appspot.com/9558003/diff/1/content/content_resourc...
content/content_resources.gyp:19: 'inputs': [
On 2012/02/29 22:16:43, bradn wrote:
> You shouldn't have the 'inputs' and 'outputs' sections, the copies section is
> adequate. Gyp's super cool parser is likely ignore these.

Done.

[bradn, 2012-02-29 22:28:27]

LGTM

[commit-bot: I haz the power, 2012-02-29 22:30:09]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mmaxfield@google.com/9558003/3001

[commit-bot: I haz the power, 2012-02-29 23:11:14]

Try job failure for 9558003-3001 (retry) on linux_rel for step "compile"
(clobber build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

[bradn, 2012-02-29 23:16:34]

https://chromiumcodereview.appspot.com/9558003/diff/3001/content/content_reso...
File content/content_resources.gyp (right):

https://chromiumcodereview.appspot.com/9558003/diff/3001/content/content_reso...
content/content_resources.gyp:40: 'includes': [ '../build/grit_target.gypi' ],
I think your try job is failing because you'll need this include in the other
target, as it publishes include_dirs to dependents.
http://src.chromium.org/viewvc/chrome/trunk/src/build/grit_target.gypi?revisi...

[Myles C. Maxfield, 2012-02-29 23:36:46]

Thanks for helping me out on this.

https://chromiumcodereview.appspot.com/9558003/diff/3001/content/content_reso...
File content/content_resources.gyp (right):

https://chromiumcodereview.appspot.com/9558003/diff/3001/content/content_reso...
content/content_resources.gyp:40: 'includes': [ '../build/grit_target.gypi' ],
On 2012/02/29 23:16:34, bradn wrote:
> I think your try job is failing because you'll need this include in the other
> target, as it publishes include_dirs to dependents.
>
http://src.chromium.org/viewvc/chrome/trunk/src/build/grit_target.gypi?revisi...

Done.

[commit-bot: I haz the power, 2012-02-29 23:37:47]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mmaxfield@google.com/9558003/4002

[commit-bot: I haz the power, 2012-03-01 03:02:00]

Change committed as 124345